[PR #6598] [MERGED] Add wrapped named variants to UserDecryptionOptions #7452

Closed
opened 2026-03-07 21:17:49 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6598
Author: @dani-garcia
Created: 12/27/2025
Status: Merged
Merged: 12/27/2025
Merged by: @dani-garcia

Base: mainHead: add-wrapped-variant


📝 Commits (1)

  • c91563b Add wrapped named variants to UserDecryptionOptions

📊 Changes

2 files changed (+6 additions, -0 deletions)

View changed files

📝 src/api/core/ciphers.rs (+3 -0)
📝 src/api/identity.rs (+3 -0)

📄 Description

The android app indicates that this field has an inconsistent naming and will be renamed in the future to masterKeyWrappedUserKey. The apps should handle that change in a backwards compatible way, but we can send both just to be safe. I'll make a note to come back and clean this up in three months or so, when the apps are updated.

Reference: https://github.com/bitwarden/android/blob/release/2025.12-rc41/network/src/main/kotlin/com/bitwarden/network/model/MasterPasswordUnlockDataJson.kt#L22-L26


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6598 **Author:** [@dani-garcia](https://github.com/dani-garcia) **Created:** 12/27/2025 **Status:** ✅ Merged **Merged:** 12/27/2025 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `add-wrapped-variant` --- ### 📝 Commits (1) - [`c91563b`](https://github.com/dani-garcia/vaultwarden/commit/c91563b4bd3bc488a6b34597191f9468e856b308) Add wrapped named variants to UserDecryptionOptions ### 📊 Changes **2 files changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+3 -0) 📝 `src/api/identity.rs` (+3 -0) </details> ### 📄 Description The android app indicates that this field has an inconsistent naming and will be renamed in the future to `masterKeyWrappedUserKey`. The apps should handle that change in a backwards compatible way, but we can send both just to be safe. I'll make a note to come back and clean this up in three months or so, when the apps are updated. Reference: https://github.com/bitwarden/android/blob/release/2025.12-rc41/network/src/main/kotlin/com/bitwarden/network/model/MasterPasswordUnlockDataJson.kt#L22-L26 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-07 21:17:49 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#7452