[PR #5993] [MERGED] Misc Updates and favicon fixes #7336

New Issue

GiteaMirror · 2026-03-07T21:15:27-06:00

GiteaMirror commented

2026-03-07 21:15:27 -06:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5993
Author: @BlackDex
Created: 6/27/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @dani-garcia

Base: main ← Head: update-icon-fetching

📝 Commits (1)

5ff3ed7 Misc Updates and favicon fixes

📊 Changes

9 files changed (+259 additions, -195 deletions)

View changed files

📝 Cargo.lock (+141 -134)
📝 Cargo.toml (+7 -7)
📝 docker/DockerSettings.yaml (+1 -1)
📝 docker/Dockerfile.alpine (+4 -4)
📝 docker/Dockerfile.debian (+1 -1)
📝 macros/Cargo.toml (+1 -1)
📝 rust-toolchain.toml (+1 -1)
📝 src/api/icons.rs (+51 -3)
📝 src/util.rs (+52 -43)

📄 Description

Updated crates
Switched to rustls instead of native-tls Some dependency were already using rustls by default or without option. By removing native-tls we also have just one way of working here.

Updated favicon fetching which now is able to fetch more icons.

Use rustls instead of native-tls This seems to work better, probably because of tls sniffing
Use different user-agent and added several other headers
Added SVG support. SVG Images will be sanitized first before stored or presented. Also, a special CSP for images will be sent to prevent scripts etc.. from SVG images.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5993 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 6/27/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `update-icon-fetching` --- ### 📝 Commits (1) - [`5ff3ed7`](https://github.com/dani-garcia/vaultwarden/commit/5ff3ed748336c75215a73ab5dd93dff893f12542) Misc Updates and favicon fixes ### 📊 Changes **9 files changed** (+259 additions, -195 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+141 -134) 📝 `Cargo.toml` (+7 -7) 📝 `docker/DockerSettings.yaml` (+1 -1) 📝 `docker/Dockerfile.alpine` (+4 -4) 📝 `docker/Dockerfile.debian` (+1 -1) 📝 `macros/Cargo.toml` (+1 -1) 📝 `rust-toolchain.toml` (+1 -1) 📝 `src/api/icons.rs` (+51 -3) 📝 `src/util.rs` (+52 -43) </details> ### 📄 Description - Updated crates - Switched to rustls instead of native-tls Some dependency were already using rustls by default or without option. By removing native-tls we also have just one way of working here. Updated favicon fetching which now is able to fetch more icons. - Use rustls instead of native-tls This seems to work better, probably because of tls sniffing - Use different user-agent and added several other headers - Added SVG support. SVG Images will be sanitized first before stored or presented. Also, a special CSP for images will be sent to prevent scripts etc.. from SVG images. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-03-07 21:15:27 -06:00

GiteaMirror closed this issue

2026-03-07 21:15:28 -06:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#7336