Realized that with the current logic Yubico is considered enabled when both client and secret are not set.
The provider is then visible but trying to enable it will result in the failure:
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5833
**Author:** [@Timshel](https://github.com/Timshel)
**Created:** 5/5/2025
**Status:** ✅ Merged
**Merged:** 5/12/2025
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `fix/yubico`
---
### 📝 Commits (1)
- [`be98da7`](https://github.com/dani-garcia/vaultwarden/commit/be98da7047001b957523732c135bfed973253a80) Fix Yubico toggle
### 📊 Changes
**1 file changed** (+1 additions, -1 deletions)
<details>
<summary>View changed files</summary>
📝 `src/api/web.rs` (+1 -1)
</details>
### 📄 Description
While testing the toggle for https://github.com/dani-garcia/vaultwarden/pull/5832
Realized that with the current logic Yubico is considered enabled when both client and secret are not set.
The provider is then visible but trying to enable it will result in the failure:
Cf: [yubikey.rs#L69](https://github.com/dani-garcia/vaultwarden/blob/2697fe8aba9b082aca02b48990bc65e9fc526aa4/src/api/core/two_factor/yubikey.rs#L69)
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/5833
Author: @Timshel
Created: 5/5/2025
Status: ✅ Merged
Merged: 5/12/2025
Merged by: @dani-garcia
Base:
main← Head:fix/yubico📝 Commits (1)
be98da7Fix Yubico toggle📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
src/api/web.rs(+1 -1)📄 Description
While testing the toggle for https://github.com/dani-garcia/vaultwarden/pull/5832
Realized that with the current logic Yubico is considered enabled when both client and secret are not set.
The provider is then visible but trying to enable it will result in the failure:
Cf: yubikey.rs#L69
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.