[PR #5386] [MERGED] Add manage role for collections and groups #7252

New Issue

GiteaMirror · 2026-03-07T21:13:42-06:00

GiteaMirror commented

2026-03-07 21:13:42 -06:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5386
Author: @BlackDex
Created: 1/12/2025
Status: ✅ Merged
Merged: 1/21/2025
Merged by: @dani-garcia

Base: main ← Head: add-manage-role

📝 Commits (2)

07e4813 Add manage role for collections and groups
cc09bb7 Fix an issue with access_all

📊 Changes

16 files changed (+184 additions, -70 deletions)

View changed files

➕ migrations/mysql/2025-01-09-172300_add_manage/down.sql (+0 -0)
➕ migrations/mysql/2025-01-09-172300_add_manage/up.sql (+5 -0)
➕ migrations/postgresql/2025-01-09-172300_add_manage/down.sql (+0 -0)
➕ migrations/postgresql/2025-01-09-172300_add_manage/up.sql (+5 -0)
➕ migrations/sqlite/2025-01-09-172300_add_manage/down.sql (+0 -0)
➕ migrations/sqlite/2025-01-09-172300_add_manage/up.sql (+5 -0)
📝 src/api/core/organizations.rs (+32 -20)
📝 src/api/icons.rs (+1 -3)
📝 src/api/notifications.rs (+0 -2)
📝 src/db/models/cipher.rs (+30 -20)
📝 src/db/models/collection.rs (+75 -15)
📝 src/db/models/group.rs (+16 -3)
📝 src/db/models/organization.rs (+9 -7)
📝 src/db/schemas/mysql/schema.rs (+2 -0)
📝 src/db/schemas/postgresql/schema.rs (+2 -0)
📝 src/db/schemas/sqlite/schema.rs (+2 -0)

📄 Description

This commit will add the manage role/column to collections and groups. We need this to allow users part of a collection either directly or via groups to be able to delete ciphers. Without this, they are only able to either edit or view them when using new clients, since these check the manage role.

Still trying to keep it compatible with previous versions and able to revert to an older Vaultwarden version and the access_all feature of the older installations. In a future version we should really check and fix these rights and create some kind of migration step to also remove the access_all feature and convert that to a manage option. But this commit at least creates the base for this already.

This should resolve #5367

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5386 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 1/12/2025 **Status:** ✅ Merged **Merged:** 1/21/2025 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `add-manage-role` --- ### 📝 Commits (2) - [`07e4813`](https://github.com/dani-garcia/vaultwarden/commit/07e48132a27aad8de06d0aacc4e8a943da380928) Add manage role for collections and groups - [`cc09bb7`](https://github.com/dani-garcia/vaultwarden/commit/cc09bb72cabfdca5df74f061e9ba7d8e8b74a1ef) Fix an issue with access_all ### 📊 Changes **16 files changed** (+184 additions, -70 deletions) <details> <summary>View changed files</summary> ➕ `migrations/mysql/2025-01-09-172300_add_manage/down.sql` (+0 -0) ➕ `migrations/mysql/2025-01-09-172300_add_manage/up.sql` (+5 -0) ➕ `migrations/postgresql/2025-01-09-172300_add_manage/down.sql` (+0 -0) ➕ `migrations/postgresql/2025-01-09-172300_add_manage/up.sql` (+5 -0) ➕ `migrations/sqlite/2025-01-09-172300_add_manage/down.sql` (+0 -0) ➕ `migrations/sqlite/2025-01-09-172300_add_manage/up.sql` (+5 -0) 📝 `src/api/core/organizations.rs` (+32 -20) 📝 `src/api/icons.rs` (+1 -3) 📝 `src/api/notifications.rs` (+0 -2) 📝 `src/db/models/cipher.rs` (+30 -20) 📝 `src/db/models/collection.rs` (+75 -15) 📝 `src/db/models/group.rs` (+16 -3) 📝 `src/db/models/organization.rs` (+9 -7) 📝 `src/db/schemas/mysql/schema.rs` (+2 -0) 📝 `src/db/schemas/postgresql/schema.rs` (+2 -0) 📝 `src/db/schemas/sqlite/schema.rs` (+2 -0) </details> ### 📄 Description This commit will add the manage role/column to collections and groups. We need this to allow users part of a collection either directly or via groups to be able to delete ciphers. Without this, they are only able to either edit or view them when using new clients, since these check the manage role. Still trying to keep it compatible with previous versions and able to revert to an older Vaultwarden version and the `access_all` feature of the older installations. In a future version we should really check and fix these rights and create some kind of migration step to also remove the `access_all` feature and convert that to a `manage` option. But this commit at least creates the base for this already. This should resolve #5367 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-03-07 21:13:42 -06:00

GiteaMirror closed this issue

2026-03-07 21:13:42 -06:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#7252