[PR #4862] [MERGED] Fix Duo Redirect not using path #7154

Closed
opened 2026-03-07 21:11:55 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4862
Author: @BlackDex
Created: 8/15/2024
Status: Merged
Merged: 8/15/2024
Merged by: @dani-garcia

Base: mainHead: fix-duo-redirect


📝 Commits (1)

  • 37ecd30 Fix Duo Redirect not using path

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/api/core/two_factor/duo_oidc.rs (+1 -1)

📄 Description

The URL crate treats https://domain.tld/path differently then https://domain.tld/path/ the latter will make sure a .join() will append the given path instead of using the base as a relative path.

Fixes #4858


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4862 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 8/15/2024 **Status:** ✅ Merged **Merged:** 8/15/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-duo-redirect` --- ### 📝 Commits (1) - [`37ecd30`](https://github.com/dani-garcia/vaultwarden/commit/37ecd30c890651bbf9a6b993883228cc32570f73) Fix Duo Redirect not using path ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/two_factor/duo_oidc.rs` (+1 -1) </details> ### 📄 Description The URL crate treats `https://domain.tld/path` differently then `https://domain.tld/path/` the latter will make sure a `.join()` will append the given path instead of using the base as a relative path. Fixes #4858 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-07 21:11:55 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#7154