github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-05-22 08:03:47 -05:00
Code Issues 307 Packages Projects Releases 83 Wiki Activity

[PR #4800] [MERGED] fix issue with adding ciphers to organizations on native ios app #7137

New Issue
Closed
opened 2026-03-07 21:11:38 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-07 21:11:38 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4800
Author: @stefan0xC
Created: 7/30/2024
Status: ✅ Merged
Merged: 7/30/2024
Merged by: @dani-garcia

Base: main ← Head: fix-ios-issue

📝 Commits (2)

  • 8174204 add organizationID alias for native ios
  • 69385fc add reverse sanity check

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/api/core/ciphers.rs (+5 -0)

📄 Description

This should fix the issues reported in #4767 where an entry added via the native iOS app cannot be decrypted:
Screenshot 2024-07-30 at 08-46-28 353277473-652ee101-fd1e-4a6d-af6a-510dd90f4994 mp4

The problem seems to be that the iOS app sends an organizationID which serde fails to deseralize and because it's an optional argument adding the cipher will not fail but it will be added incorrectly to your personal vault, unless you have disabled personal ownerships. So to prevent such corruptions from occurring again I've added a reverse sanity check, just in case some other clients send the organization_id in an unrecognizable format.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4800 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 7/30/2024 **Status:** ✅ Merged **Merged:** 7/30/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-ios-issue` --- ### 📝 Commits (2) - [`8174204`](https://github.com/dani-garcia/vaultwarden/commit/8174204aa4a1f7fa24691126257875768f933a66) add organizationID alias for native ios - [`69385fc`](https://github.com/dani-garcia/vaultwarden/commit/69385fcc57ea1ef59c118fdfde853b282393ae2c) add reverse sanity check ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+5 -0) </details> ### 📄 Description This should fix the issues reported in #4767 where an entry added via the native iOS app cannot be decrypted: ![Screenshot 2024-07-30 at 08-46-28 353277473-652ee101-fd1e-4a6d-af6a-510dd90f4994 mp4](https://github.com/user-attachments/assets/73be06a8-ca61-4a8c-9355-7ab210c4286e) The problem seems to be that the iOS app sends an [organizationID](https://github.com/bitwarden/ios/blob/3ec242eb73735608fbed32837303b22ceb531abb/BitwardenShared/Core/Vault/Models/Request/CipherRequestModel.swift#L47) which serde fails to deseralize and because it's an optional argument adding the cipher will not fail but it will be added incorrectly to your personal vault, unless you have disabled personal ownerships. So to prevent such corruptions from occurring again I've added a reverse sanity check, just in case some other clients send the organization_id in an unrecognizable format. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-07 21:11:38 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#7137
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?