[PR #4779] [MERGED] Duo: use the formatted db email #7132

New Issue

GiteaMirror · 2026-03-07T21:11:33-06:00

GiteaMirror commented

2026-03-07 21:11:33 -06:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4779
Author: @Timshel
Created: 7/25/2024
Status: ✅ Merged
Merged: 7/25/2024
Merged by: @dani-garcia

Base: main ← Head: fix/duo

📝 Commits (1)

18d40c1 Duo: use the formatted db email

📊 Changes

2 files changed (+2 additions, -4 deletions)

View changed files

📝 src/api/core/two_factor/duo_oidc.rs (+0 -2)
📝 src/api/identity.rs (+2 -2)

📄 Description

Was rebasing and had a conflict with the latest addition of validate_duo_login.
Had made the fix for the OpenID PR and never back-ported it (Don't exactly remember the issue and it's buried in the comments, but it was linked to using the non lowercased email).

I think in general it makes more sense if available to use the reference email from the user instead of the non formatted value from the form.
I don't have a Duo account anymore so can't really test it :(.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4779 **Author:** [@Timshel](https://github.com/Timshel) **Created:** 7/25/2024 **Status:** ✅ Merged **Merged:** 7/25/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix/duo` --- ### 📝 Commits (1) - [`18d40c1`](https://github.com/dani-garcia/vaultwarden/commit/18d40c108e790c3965c16b70458bc2a1e9a0d0f1) Duo: use the formatted db email ### 📊 Changes **2 files changed** (+2 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/two_factor/duo_oidc.rs` (+0 -2) 📝 `src/api/identity.rs` (+2 -2) </details> ### 📄 Description Was rebasing and had a conflict with the latest addition of `validate_duo_login`. Had made the fix for the OpenID PR and never back-ported it (Don't exactly remember the issue and it's buried in the comments, but it was linked to using the non lowercased email). I think in general it makes more sense if available to use the reference email from the user instead of the non formatted value from the form. I don't have a Duo account anymore so can't really test it :(. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-03-07 21:11:33 -06:00

GiteaMirror closed this issue

2026-03-07 21:11:34 -06:00

GiteaMirror referenced this issue

2026-04-25 21:56:39 -05:00

[GH-ISSUE #7132] Visual Bug in 1.35.8 #19395

GiteaMirror referenced this issue

2026-05-16 06:00:21 -05:00

[PR #7171] [MERGED] Update crates and web-vault #23421

Sign in to join this conversation.