[PR #4702] [MERGED] Fix duplicate folder creations during import #7115

Closed
opened 2026-03-07 21:11:17 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4702
Author: @BlackDex
Created: 7/4/2024
Status: Merged
Merged: 7/4/2024
Merged by: @dani-garcia

Base: mainHead: fix-duplicate-folder-on-import


📝 Commits (1)

  • 30b4579 Fix duplicate folder creations during import

📊 Changes

2 files changed (+14 additions, -6 deletions)

View changed files

📝 src/api/core/ciphers.rs (+13 -6)
📝 src/api/core/folders.rs (+1 -0)

📄 Description

During import you are able to select an existing folder, or with Bitwarden exports it can contain existing folders already. In either case it didn't matter, we always created new folders.

Bitwarden uses the same UUID of the selected or existing folders if they are already there.

This PR fixes this by using the same behaviour.

Fixes #4700


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4702 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 7/4/2024 **Status:** ✅ Merged **Merged:** 7/4/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-duplicate-folder-on-import` --- ### 📝 Commits (1) - [`30b4579`](https://github.com/dani-garcia/vaultwarden/commit/30b457994a9b7e1b191dc20dd34b021e4f31fc13) Fix duplicate folder creations during import ### 📊 Changes **2 files changed** (+14 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+13 -6) 📝 `src/api/core/folders.rs` (+1 -0) </details> ### 📄 Description During import you are able to select an existing folder, or with Bitwarden exports it can contain existing folders already. In either case it didn't matter, we always created new folders. Bitwarden uses the same UUID of the selected or existing folders if they are already there. This PR fixes this by using the same behaviour. Fixes #4700 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-07 21:11:17 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#7115