github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-07-17 17:32:27 -05:00
Code Issues 485 Packages Projects Releases 83 Wiki Activity

[PR #4282] [MERGED] Fix attachment upload size check #7045

New Issue
Closed
opened 2026-03-07 21:10:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-07 21:10:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4282
Author: @BlackDex
Created: 1/28/2024
Status: ✅ Merged
Merged: 1/28/2024
Merged by: @dani-garcia

Base: main ← Head: fix-attachment-size-check

📝 Commits (1)

  • 0ad94c4 Fix attachment upload size check

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 src/api/core/ciphers.rs (+4 -4)

📄 Description

The min/max were reversed with the add and sub functions. This caused the files to always be out of bounds in the check.

Fixes #4281

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4282 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 1/28/2024 **Status:** ✅ Merged **Merged:** 1/28/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-attachment-size-check` --- ### 📝 Commits (1) - [`0ad94c4`](https://github.com/dani-garcia/vaultwarden/commit/0ad94c4dc332152502fffb43b28272a56082fb2c) Fix attachment upload size check ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/ciphers.rs` (+4 -4) </details> ### 📄 Description The min/max were reversed with the `add` and `sub` functions. This caused the files to always be out of bounds in the check. Fixes #4281 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-07 21:10:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#7045
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?