[PR #3251] [MERGED] Validate all needed fields for client API login #6891

Closed
opened 2026-03-07 21:07:31 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3251
Author: @BlackDex
Created: 2/16/2023
Status: Merged
Merged: 2/21/2023
Merged by: @dani-garcia

Base: mainHead: fix-client-api-login-checks


📝 Commits (1)

  • 1ca0d6e Validate all needed fields for client API login

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 src/api/identity.rs (+4 -0)

📄 Description

During the client API login we need to have a device_identifier, device_name and device_type.
When these were not provided Vaultwarden would panic.

This PR add checks for these fields and makes sure it returns a better error message instead of causing a panic.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3251 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 2/16/2023 **Status:** ✅ Merged **Merged:** 2/21/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-client-api-login-checks` --- ### 📝 Commits (1) - [`1ca0d6e`](https://github.com/dani-garcia/vaultwarden/commit/1ca0d6e2451ae6f68b0325e7ae9f1233185bbb68) Validate all needed fields for client API login ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/api/identity.rs` (+4 -0) </details> ### 📄 Description During the client API login we need to have a `device_identifier`, `device_name` and `device_type`. When these were not provided Vaultwarden would panic. This PR add checks for these fields and makes sure it returns a better error message instead of causing a panic. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-07 21:07:31 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#6891