[PR #3215] [MERGED] don't nullify key when editing emergency access #6884

New Issue

Closed

opened 2026-03-07 21:07:25 -06:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-03-07 21:07:25 -06:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3215
Author: @stefan0xC
Created: 2/1/2023
Status: ✅ Merged
Merged: 2/12/2023
Merged by: @dani-garcia

Base: main ← Head: fix-post-emergency-access

---

📝 Commits (2)

• e65fbbf don't nullify key when editing emergency access
• c58aac5 Merge branch 'main' into fix-post-emergency-access

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/api/core/emergency_access.rs (+3 -1)

📄 Description

I've looked into this some more and the client does not send the key while editing an emergency access contact, so the field would be emptied on a change of the wait days or access level.

This simple fix should hopefully prevent issues like #3196 where the key has been set to NULL.

Closes #3196

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3215 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 2/1/2023 **Status:** ✅ Merged **Merged:** 2/12/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-post-emergency-access` --- ### 📝 Commits (2) - [`e65fbbf`](https://github.com/dani-garcia/vaultwarden/commit/e65fbbfc2105566a3c457dd34d3ae790ce7f4fb5) don't nullify key when editing emergency access - [`c58aac5`](https://github.com/dani-garcia/vaultwarden/commit/c58aac585ba15ae7b02123e9d5eef5d398e37ff5) Merge branch 'main' into fix-post-emergency-access ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/emergency_access.rs` (+3 -1) </details> ### 📄 Description I've looked into this some more and the client [does not send the key](https://github.com/bitwarden/clients/blob/7ebedbecfbbdfe17b011ca6490bf98fdd5116016/apps/web/src/app/settings/emergency-access-add-edit.component.ts#L74-L78) while editing an emergency access contact, so the field would be emptied on a change of the wait days or access level. This simple fix should hopefully prevent issues like #3196 where the key has been set to `NULL`. Closes #3196 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-03-07 21:07:25 -06:00

GiteaMirror closed this issue 2026-03-07 21:07:25 -06:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

cached-config-operations

test_dylint

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#6884