[PR #1973] [MERGED] Optimize release workflow. #6673

New Issue

Closed

opened 2026-03-07 21:02:51 -06:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-03-07 21:02:51 -06:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1973
Author: @BlackDex
Created: 9/13/2021
Status: ✅ Merged
Merged: 9/13/2021
Merged by: @dani-garcia

Base: main ← Head: optimize-release

---

📝 Commits (1)

• ca0fd7a Optimize release workflow.

📊 Changes

19 files changed (+1170 additions, -193 deletions)

View changed files

📝 .github/workflows/build.yml (+12 -33)
📝 .github/workflows/hadolint.yml (+1 -1)
📝 .github/workflows/release.yml (+21 -7)
📝 docker/Dockerfile.j2 (+65 -44)
📝 docker/Makefile (+6 -0)
📝 docker/amd64/Dockerfile (+19 -7)
📝 docker/amd64/Dockerfile.alpine (+12 -4)
➕ docker/amd64/Dockerfile.buildx (+126 -0)
➕ docker/amd64/Dockerfile.buildx.alpine (+118 -0)
📝 docker/arm64/Dockerfile (+45 -30)
➕ docker/arm64/Dockerfile.buildx (+169 -0)
📝 docker/armv6/Dockerfile (+45 -30)
➕ docker/armv6/Dockerfile.buildx (+169 -0)
📝 docker/armv7/Dockerfile (+45 -30)
📝 docker/armv7/Dockerfile.alpine (+12 -4)
➕ docker/armv7/Dockerfile.buildx (+169 -0)
➕ docker/armv7/Dockerfile.buildx.alpine (+125 -0)
📝 hooks/build (+6 -1)
📝 hooks/push (+5 -2)

📄 Description

• Split Debian and Alpine into different build matrix
  This starts building both Debian and Alpine based images at the same time
• Make use of Docker BuildKit, which improves speed also.
• Use BuildKit caching for Rust Cargo across docker images.
  This prevents downloading the same crates multiple times.
• Use Github Actions Services to start a docker registry, starting it
  via the build script sometimes caused issues.
• Updated the Build workflow to use Ubuntu 20.04 which is more close to
  the Bullseye Debian release regarding package versions.

As a side-note, i also tried adding the apt files to the cache, it did not cause any change into the build-time (both local and on GHA) so to have less complexity i did not add it.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1973 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 9/13/2021 **Status:** ✅ Merged **Merged:** 9/13/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `optimize-release` --- ### 📝 Commits (1) - [`ca0fd7a`](https://github.com/dani-garcia/vaultwarden/commit/ca0fd7a31b724d06ba4eca203bfeda9e38c5e767) Optimize release workflow. ### 📊 Changes **19 files changed** (+1170 additions, -193 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+12 -33) 📝 `.github/workflows/hadolint.yml` (+1 -1) 📝 `.github/workflows/release.yml` (+21 -7) 📝 `docker/Dockerfile.j2` (+65 -44) 📝 `docker/Makefile` (+6 -0) 📝 `docker/amd64/Dockerfile` (+19 -7) 📝 `docker/amd64/Dockerfile.alpine` (+12 -4) ➕ `docker/amd64/Dockerfile.buildx` (+126 -0) ➕ `docker/amd64/Dockerfile.buildx.alpine` (+118 -0) 📝 `docker/arm64/Dockerfile` (+45 -30) ➕ `docker/arm64/Dockerfile.buildx` (+169 -0) 📝 `docker/armv6/Dockerfile` (+45 -30) ➕ `docker/armv6/Dockerfile.buildx` (+169 -0) 📝 `docker/armv7/Dockerfile` (+45 -30) 📝 `docker/armv7/Dockerfile.alpine` (+12 -4) ➕ `docker/armv7/Dockerfile.buildx` (+169 -0) ➕ `docker/armv7/Dockerfile.buildx.alpine` (+125 -0) 📝 `hooks/build` (+6 -1) 📝 `hooks/push` (+5 -2) </details> ### 📄 Description - Split Debian and Alpine into different build matrix This starts building both Debian and Alpine based images at the same time - Make use of Docker BuildKit, which improves speed also. - Use BuildKit caching for Rust Cargo across docker images. This prevents downloading the same crates multiple times. - Use Github Actions Services to start a docker registry, starting it via the build script sometimes caused issues. - Updated the Build workflow to use Ubuntu 20.04 which is more close to the Bullseye Debian release regarding package versions. As a side-note, i also tried adding the apt files to the cache, it did not cause any change into the build-time (both local and on GHA) so to have less complexity i did not add it. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-03-07 21:02:51 -06:00

GiteaMirror closed this issue 2026-03-07 21:02:52 -06:00

GiteaMirror referenced this issue 2026-03-07 21:18:01 -06:00

[PR #6673] [MERGED] allow MasterPasswordHash for Android #7462

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

cached-config-operations

test_dylint

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#6673