[PR #1881] [MERGED] Fix sends notification format and add endpoints to get all sends or one send by id #6660

Closed
opened 2026-03-07 21:02:38 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1881
Author: @fabianthdev
Created: 8/3/2021
Status: Merged
Merged: 8/22/2021
Merged by: @dani-garcia

Base: mainHead: fix/sends_notifications


📝 Commits (3)

  • dd98fe8 Send create, update and delete notifications for Sends in the correct format.
  • 42ba817 Fix errors that occurred in the nightly build
  • 1f0f64d Sort the imports in notifications.rs alphabetically

📊 Changes

3 files changed (+58 additions, -10 deletions)

View changed files

📝 src/api/core/sends.rs (+35 -7)
📝 src/api/notifications.rs (+18 -1)
📝 src/db/models/send.rs (+5 -2)

📄 Description

This small pull request fixes the notification format for SyncSendCreate, SyncSendUpdate and SyncSendDeletenotification types.

With the correct notification format, the sends in the web vault and other bitwarden clients are automatically updated when the user creates, updates or deletes a send in another session. To allow the clients to update specific sends, this PR also includes new endpoints for getting all sends or one specific send by uuid.

I've verified that this works with the web vault and the bitwarden mobile client.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1881 **Author:** [@fabianthdev](https://github.com/fabianthdev) **Created:** 8/3/2021 **Status:** ✅ Merged **Merged:** 8/22/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix/sends_notifications` --- ### 📝 Commits (3) - [`dd98fe8`](https://github.com/dani-garcia/vaultwarden/commit/dd98fe860b33f8e34c161f49e3f6b07908d1dc3e) Send create, update and delete notifications for `Send`s in the correct format. - [`42ba817`](https://github.com/dani-garcia/vaultwarden/commit/42ba817a4c423457a014f13cec3faba994770b21) Fix errors that occurred in the nightly build - [`1f0f64d`](https://github.com/dani-garcia/vaultwarden/commit/1f0f64d961cd8839bcd5be6336f68d44b40aaa21) Sort the imports in notifications.rs alphabetically ### 📊 Changes **3 files changed** (+58 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/sends.rs` (+35 -7) 📝 `src/api/notifications.rs` (+18 -1) 📝 `src/db/models/send.rs` (+5 -2) </details> ### 📄 Description This small pull request fixes the notification format for `SyncSendCreate`, `SyncSendUpdate` and `SyncSendDelete`notification types. With the correct notification format, the sends in the web vault and other bitwarden clients are automatically updated when the user creates, updates or deletes a send in another session. To allow the clients to update specific sends, this PR also includes new endpoints for getting all sends or one specific send by uuid. I've verified that this works with the web vault and the bitwarden mobile client. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-07 21:02:38 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#6660