[PR #1579] [MERGED] Add support for auto-deleting trashed items #6619

Closed
opened 2026-03-07 21:01:52 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1579
Author: @jjlin
Created: 4/3/2021
Status: Merged
Merged: 4/6/2021
Merged by: @dani-garcia

Base: masterHead: job-scheduler


📝 Commits (3)

  • 73ff8d7 Add a generic job scheduler
  • d773335 Add support for auto-deleting trashed items
  • 90e0b7f Offset scheduled jobs by 5 minutes

📊 Changes

11 files changed (+180 additions, -33 deletions)

View changed files

📝 .env.template (+17 -0)
📝 Cargo.lock (+32 -1)
📝 Cargo.toml (+10 -0)
📝 src/api/core/ciphers.rs (+10 -1)
📝 src/api/core/mod.rs (+2 -1)
📝 src/api/core/sends.rs (+8 -16)
📝 src/api/mod.rs (+2 -1)
📝 src/config.rs (+16 -0)
📝 src/db/models/cipher.rs (+23 -1)
📝 src/db/models/send.rs (+16 -6)
📝 src/main.rs (+44 -6)

📄 Description

Upstream will soon auto-delete trashed items after 30 days, but some people use the trash as an archive folder, so to avoid unexpected data loss, this implementation requires the user to explicitly enable auto-deletion.

This PR also adds a generic job scheduler, and rewrites deletion of old sends to use it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1579 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 4/3/2021 **Status:** ✅ Merged **Merged:** 4/6/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `job-scheduler` --- ### 📝 Commits (3) - [`73ff8d7`](https://github.com/dani-garcia/vaultwarden/commit/73ff8d79f70b36483d1d33587cdc9549c8e472bd) Add a generic job scheduler - [`d773335`](https://github.com/dani-garcia/vaultwarden/commit/d77333576b1268cd24f17348ffe6d72e07855f54) Add support for auto-deleting trashed items - [`90e0b7f`](https://github.com/dani-garcia/vaultwarden/commit/90e0b7fec6cc025561f9f732fb06d15f72e5c892) Offset scheduled jobs by 5 minutes ### 📊 Changes **11 files changed** (+180 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+17 -0) 📝 `Cargo.lock` (+32 -1) 📝 `Cargo.toml` (+10 -0) 📝 `src/api/core/ciphers.rs` (+10 -1) 📝 `src/api/core/mod.rs` (+2 -1) 📝 `src/api/core/sends.rs` (+8 -16) 📝 `src/api/mod.rs` (+2 -1) 📝 `src/config.rs` (+16 -0) 📝 `src/db/models/cipher.rs` (+23 -1) 📝 `src/db/models/send.rs` (+16 -6) 📝 `src/main.rs` (+44 -6) </details> ### 📄 Description Upstream will soon auto-delete trashed items after 30 days, but some people use the trash as an archive folder, so to avoid unexpected data loss, this implementation requires the user to explicitly enable auto-deletion. This PR also adds a generic job scheduler, and rewrites deletion of old sends to use it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-07 21:01:52 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#6619