github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-03-11 17:41:29 -05:00
Code Issues 79 Packages Projects Releases 78 Wiki Activity

[PR #1135] [MERGED] Updated lettre (and other crates) and workflow. #6533

New Issue
Closed
opened 2026-03-07 21:00:32 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-03-07 21:00:32 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1135
Author: @BlackDex
Created: 9/11/2020
Status: ✅ Merged
Merged: 9/13/2020
Merged by: @dani-garcia

Base: master ← Head: update-mail

📝 Commits (1)

  • 844cf70 Updated lettre (and other crates) and workflow.

📊 Changes

4 files changed (+139 additions, -172 deletions)

View changed files

📝 Cargo.lock (+98 -119)
📝 Cargo.toml (+13 -13)
📝 src/error.rs (+1 -1)
📝 src/mail.rs (+27 -39)

📄 Description

General:

  • Updated several dependancies

Lettre:

  • Updateded lettere and the workflow
  • Changed encoding to base64
  • Convert unix newlines to dos newlines for e-mails.
  • Created custom e-mail boundary (auto generated could cause errors)

Tested the e-mails sent using several clients (Linux, Windows, MacOS, Web).
Run msglint (https://tools.ietf.org/tools/msglint/) on the generated e-mails until all errors were gone.

Lettre has changed quite some stuff compared between alpha.1 and alpha.2, i haven't noticed any issues sending e-mails during my tests.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1135 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 9/11/2020 **Status:** ✅ Merged **Merged:** 9/13/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `update-mail` --- ### 📝 Commits (1) - [`844cf70`](https://github.com/dani-garcia/vaultwarden/commit/844cf70345733fbcf2bd0a15cc45aa0040b7638d) Updated lettre (and other crates) and workflow. ### 📊 Changes **4 files changed** (+139 additions, -172 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+98 -119) 📝 `Cargo.toml` (+13 -13) 📝 `src/error.rs` (+1 -1) 📝 `src/mail.rs` (+27 -39) </details> ### 📄 Description General: - Updated several dependancies Lettre: - Updateded lettere and the workflow - Changed encoding to base64 - Convert unix newlines to dos newlines for e-mails. - Created custom e-mail boundary (auto generated could cause errors) Tested the e-mails sent using several clients (Linux, Windows, MacOS, Web). Run msglint (https://tools.ietf.org/tools/msglint/) on the generated e-mails until all errors were gone. Lettre has changed quite some stuff compared between alpha.1 and alpha.2, i haven't noticed any issues sending e-mails during my tests. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-03-07 21:00:32 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#6533
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?