[PR #741] [MERGED] Add an option to fetch and parse href="data:image" #6440

New Issue

GiteaMirror · 2026-03-07T20:59:05-06:00

GiteaMirror commented

2026-03-07 20:59:05 -06:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/741
Author: @BlackDex
Created: 11/22/2019
Status: ✅ Merged
Merged: 11/22/2019
Merged by: @dani-garcia

Base: master ← Head: icon-datauri

📝 Commits (1)

b209c1b Add an option to fetch and parse href="data:image"

📊 Changes

3 files changed (+54 additions, -17 deletions)

View changed files

📝 Cargo.lock (+24 -8)
📝 Cargo.toml (+4 -0)
📝 src/api/icons.rs (+26 -9)

📄 Description

Some sites are using base64 encoded inline images for favicons.
This will try to match those with some sane checks and return that.
These icons will have lower prio then the icons with a normal URL.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/741 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 11/22/2019 **Status:** ✅ Merged **Merged:** 11/22/2019 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `icon-datauri` --- ### 📝 Commits (1) - [`b209c1b`](https://github.com/dani-garcia/vaultwarden/commit/b209c1bc4d3f31a9b7061ee2b4aef276faaef3f8) Add an option to fetch and parse href="data:image" ### 📊 Changes **3 files changed** (+54 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+24 -8) 📝 `Cargo.toml` (+4 -0) 📝 `src/api/icons.rs` (+26 -9) </details> ### 📄 Description Some sites are using base64 encoded inline images for favicons. This will try to match those with some sane checks and return that. These icons will have lower prio then the icons with a normal URL. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-03-07 20:59:05 -06:00

GiteaMirror closed this issue

2026-03-07 20:59:05 -06:00

GiteaMirror referenced this issue

2026-03-07 21:17:20 -06:00

[PR #6440] [CLOSED] Only build Alpine, stop building Debian #7416

GiteaMirror referenced this issue

2026-04-16 12:34:18 -05:00

[PR #6440] [CLOSED] Only build Alpine, stop building Debian #8716

GiteaMirror referenced this issue

2026-04-20 14:47:18 -05:00

[GH-ISSUE #6416] Deleted Items stop login working #11238