mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-03-12 09:54:49 -05:00
Import does not display the imported ciphers until you log out and back in again. #63
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/vaultwarden#63
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mannp on GitHub (Aug 6, 2018).
No errors in the log either....
Edit: It appears I have to logout of the v2 instance and log back in again for anything to appear.
Is this normal, or should a refresh be pushed after the import?
Thanks.
@mprasil commented on GitHub (Aug 6, 2018):
I think just reloading the page should do the trick.
As for why this happens, it's quite possible we just need to push some cipher info back in response, will have to test that with the official server
@mannp commented on GitHub (Aug 6, 2018):
Reloading the page didn't work for me.
I had to fully logout and back in again for it to refresh.
@mprasil commented on GitHub (Aug 6, 2018):
What version of Vault are you using?
@mannp commented on GitHub (Aug 6, 2018):
Both updated this morning.
@mprasil commented on GitHub (Aug 6, 2018):
Can you check the exact Vault version number?
@mannp commented on GitHub (Aug 6, 2018):
Where? v1.27.0 and v2.0.0, but they have always said that.
@mprasil commented on GitHub (Aug 10, 2018):
Okay, I've been looking into that and I think I understand where is the issue. The client will
POSTthe data to/api/ciphers/import. Then it will callGETon/api/accounts/revision-date. This should return timestamp of when was the account last updated. It should receive some recent timestamp and realize it did sync before that and that there are some updates pending and it should do the sync.Now there are couple issues in bitwarden_rs preventing that. One is that the revision date endpoint should return unix time in miliseconds and not seconds, client (thinking that it's in ms) then assumes that last update was done sometimes in 1970. 👴 ⏲ 😄 Hence it doesn't even try to sync as it thinks it already has newer data. (reported #127 for that)
Besides the above issue, we need to update revision date when we do the import. (this is why logging off helps you, it updates the account revision date) I've did a quick and dirty hack to test this and indeed the ciphers are loaded right after the import is done.
@mannp commented on GitHub (Aug 10, 2018):
Thanks for the investigation, seems to make sense.
@dani-garcia commented on GitHub (Aug 13, 2018):
This should be fixed now that #131 is merged
@mprasil commented on GitHub (Aug 13, 2018):
Note, that docker image is still being built, so give it about 2 hours before testing the beta image.