mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-05-07 21:15:39 -05:00
Enable client-side icon cache (HTTP Header) #585
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/vaultwarden#585
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @PrivatePuffin on GitHub (Jan 30, 2020).
Subject of the issue
Currently Icons are not cached client side, it would be nice if this gets made possible.
Expected behaviour
Icons are not a big risk being cached client side, expected would be that icons are client-cached by default or at least client-side icon caching is enabled using the web headers.
Actual behaviour
No icons are cached because the following header is set on the icons:
cache-control: no-cache, no-store, max-age=0@dani-garcia commented on GitHub (Jan 30, 2020):
Oh this makes perfect sense! Implemented in
ebb36235a7thanks!@PrivatePuffin commented on GitHub (Jan 30, 2020):
Thats... fast!
Thanks!