github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-08-27 05:35:03 -05:00
Code Issues 534 Packages Projects Releases 86 Wiki Activity

Enable client-side icon cache (HTTP Header) #585

New Issue
Closed
opened 2025-11-07 06:42:02 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-07 06:42:02 -06:00
Owner
Copy Link
Copy Source

Originally created by @PrivatePuffin on GitHub (Jan 30, 2020).

Subject of the issue

Currently Icons are not cached client side, it would be nice if this gets made possible.

Expected behaviour

Icons are not a big risk being cached client side, expected would be that icons are client-cached by default or at least client-side icon caching is enabled using the web headers.

Actual behaviour

No icons are cached because the following header is set on the icons:
cache-control: no-cache, no-store, max-age=0

Originally created by @PrivatePuffin on GitHub (Jan 30, 2020). ### Subject of the issue Currently Icons are not cached client side, it would be nice if this gets made possible. ### Expected behaviour Icons are not a big risk being cached client side, expected would be that icons are client-cached by default or at least client-side icon caching is enabled using the web headers. ### Actual behaviour No icons are cached because the following header is set on the icons: `cache-control: no-cache, no-store, max-age=0`
GiteaMirror commented 2025-11-07 06:42:03 -06:00
Author
Owner
Copy Link
Copy Source

@dani-garcia commented on GitHub (Jan 30, 2020):

Oh this makes perfect sense! Implemented in https://github.com/dani-garcia/bitwarden_rs/commit/ebb36235a70a2c539a7656454de3478ae776aa22 thanks!

@dani-garcia commented on GitHub (Jan 30, 2020): Oh this makes perfect sense! Implemented in https://github.com/dani-garcia/bitwarden_rs/commit/ebb36235a70a2c539a7656454de3478ae776aa22 thanks!
GiteaMirror commented 2025-11-07 06:42:03 -06:00
Author
Owner
Copy Link
Copy Source

@PrivatePuffin commented on GitHub (Jan 30, 2020):

Thats... fast!
Thanks!

@PrivatePuffin commented on GitHub (Jan 30, 2020): Thats... fast! Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#585