github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-08-27 05:35:03 -05:00
Code Issues 534 Packages Projects Releases 86 Wiki Activity

PUT /api/ciphers/share not implemented #55

New Issue
Closed
opened 2025-11-07 06:20:43 -06:00 by GiteaMirror · 10 comments
GiteaMirror commented 2025-11-07 06:20:43 -06:00
Owner
Copy Link
Copy Source

Originally created by @mprasil on GitHub (Jul 21, 2018).

New vault (#93) calls PUT on /api/ciphers/share to "Share selected" ciphers. This functionality wasn't present in the previous vault so implementation will be a bit more involved, but should be pretty similar to "move selected".

(also woohoo! 100th issue 😄)

Originally created by @mprasil on GitHub (Jul 21, 2018). New vault (#93) calls `PUT` on `/api/ciphers/share` to "Share selected" ciphers. This functionality wasn't present in the previous vault so implementation will be a bit more involved, but should be pretty similar to "move selected". (also woohoo! 100th issue :smile:)
GiteaMirror added the good first issuebugfuture Vault labels 2025-11-07 06:20:43 -06:00
GiteaMirror commented 2025-11-07 06:20:44 -06:00
Author
Owner
Copy Link
Copy Source

@tgturner commented on GitHub (Jul 26, 2018):

I would love to take a look at this one!

@tgturner commented on GitHub (Jul 26, 2018): I would love to take a look at this one!
GiteaMirror commented 2025-11-07 06:20:44 -06:00
Author
Owner
Copy Link
Copy Source

@mprasil commented on GitHub (Jul 26, 2018):

Go for it and don't hesitate to ask for help.

@mprasil commented on GitHub (Jul 26, 2018): Go for it and don't hesitate to ask for help.
GiteaMirror commented 2025-11-07 06:20:44 -06:00
Author
Owner
Copy Link
Copy Source

@tgturner commented on GitHub (Jul 26, 2018):

Thanks! I'll take a look at it this evening.

@tgturner commented on GitHub (Jul 26, 2018): Thanks! I'll take a look at it this evening.
GiteaMirror commented 2025-11-07 06:20:45 -06:00
Author
Owner
Copy Link
Copy Source

@krankur commented on GitHub (Aug 1, 2018):

I guess we need to add an organization in order to test the "Share" functionality, but I am not able to figure out how to add an organization? I tried uploading a random JSON file as the license file but I am getting a 401 error. Can someone please guide me on this?

@krankur commented on GitHub (Aug 1, 2018): I guess we need to add an organization in order to test the "Share" functionality, but I am not able to figure out how to add an organization? I tried uploading a random JSON file as the license file but I am getting a 401 error. Can someone please guide me on this?
GiteaMirror commented 2025-11-07 06:20:45 -06:00
Author
Owner
Copy Link
Copy Source

@mprasil commented on GitHub (Aug 1, 2018):

Hi, there's no licence required - just create free organization (the first option) and it should have all features after that.

@mprasil commented on GitHub (Aug 1, 2018): Hi, there's no licence required - just create free organization (the first option) and it should have all features after that.
GiteaMirror commented 2025-11-07 06:20:45 -06:00
Author
Owner
Copy Link
Copy Source

@dani-garcia commented on GitHub (Aug 1, 2018):

I think that happens in the self hosted version (when you build with npm run dist:selfhost)

It should work if you build the normal version (with npm run dist)

@dani-garcia commented on GitHub (Aug 1, 2018): I think that happens in the self hosted version (when you build with npm run dist:selfhost) It should work if you build the normal version (with npm run dist)
GiteaMirror commented 2025-11-07 06:20:45 -06:00
Author
Owner
Copy Link
Copy Source

@mprasil commented on GitHub (Aug 1, 2018):

@dani-garcia I submitted #109 to merge recent changes from master. We should do this before @krankur touches the sharing API as there were some major changes and will be pain to merge later.

@mprasil commented on GitHub (Aug 1, 2018): @dani-garcia I submitted #109 to merge recent changes from master. We should do this before @krankur touches the sharing API as there were some major changes and will be pain to merge later.
GiteaMirror commented 2025-11-07 06:20:46 -06:00
Author
Owner
Copy Link
Copy Source

@mprasil commented on GitHub (Aug 1, 2018):

Thanks for merging it. @krankur make sure you're working with latest beta code.

@mprasil commented on GitHub (Aug 1, 2018): Thanks for merging it. @krankur make sure you're working with latest beta code.
GiteaMirror commented 2025-11-07 06:20:46 -06:00
Author
Owner
Copy Link
Copy Source

@krankur commented on GitHub (Aug 1, 2018):

@mprasil Will do. Thanks for the heads up.

@krankur commented on GitHub (Aug 1, 2018): @mprasil Will do. Thanks for the heads up.
GiteaMirror commented 2025-11-07 06:20:46 -06:00
Author
Owner
Copy Link
Copy Source

@mprasil commented on GitHub (Aug 9, 2018):

I think this was resolved in #116

@mprasil commented on GitHub (Aug 9, 2018): I think this was resolved in #116
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No labels bug future Vault good first issue
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#55