mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-03-12 01:45:56 -05:00
Login with device not working #5317
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @martinjgrunwald on GitHub (Aug 31, 2023).
Originally assigned to: @BlackDex on GitHub.
Subject of the issue
I have some questions regarding logging in with another device
Deployment environment
Your environment (Generated via diagnostics page)
Config (Generated via diagnostics page)
Show Running Config
Environment settings which are overridden: ADMIN_TOKEN
Steps to reproduce
Opening the login page of my vaultwarden instance and typing in my mail address
Expected behaviour
Clicking on login with device, accepting the request and successfully logging in
Actual behaviour
I can only initiate logging in with another device out of a non-incognito Chrome tab. Neither an incognito-tab on Chrome nor any other browser (incognito or not) show me this option.
When I manage to send out a notification I receive this notification on my iPhone or on the Desktop App. I can accept the request but I am not logged in after accepting it.
@hydroxycarbamide commented on GitHub (Sep 1, 2023):
I have the same problem. I get the notification and try to accept but I get "We were unable to process your request. Please try again or contact us".
However, it only seems to fail when I use biometrics for unlocking on my Android client.
It seems to work every time I use my master password.
I have deleted my app data and reconnected my account before enabling Approve login requests as recommended in the wiki.
@martinjgrunwald Does it work if you use your master password to unlock your vault on your iPhone before accepting the authentication request?
@BlackDex commented on GitHub (Sep 1, 2023):
First, login with device will only work with a known device. So any incognito, never used before browser will not show that button. You first need to login using a password (and 2fa) before that button will be shown.
Second, it looks like that they made some changes in the new clients. So we need to see what that is, and make changes to support that.
@mrwulf commented on GitHub (Sep 1, 2023):
Try fully logging out of the mobile app, log back into the mobile app, and go back into options to use the mobile app to approve login requests. A clean login to the mobile app and now I can approve web and desktop logins from mobile. I'm on android
@stefan0xC commented on GitHub (Sep 1, 2023):
@BlackDex not sure what happens client side but I can at least provide the additional info that we get an empty
MasterPasswordHashfrom the client when using PIN or Biometrics to unlock a mobile app. To recreate the conditions you also need to reboot the device after connecting your app.I.e. if we turn this
Stringinto anOption<String>we could at least return a nicer error5ab7010c37/src/api/core/accounts.rs (L1093)@BlackDex commented on GitHub (Sep 1, 2023):
Strange that it did worked before. Or, i never tested with biometrics.
It also defeats the whole login with device if you need to login with a password on your phone of course.
@BlackDex commented on GitHub (Sep 1, 2023):
It might have something to do with this:
https://github.com/bitwarden/clients/issues/6156
@martinjgrunwald commented on GitHub (Sep 1, 2023):
I logged out of the BitWarden App on macOS and iOS and afterwards I was able to authenticate in a browser using any of those two. On both of them I logged in using biometrics so that works as well @BlackDex
@martinjgrunwald commented on GitHub (Sep 1, 2023):
Can be closed
@sbisbilo commented on GitHub (Sep 1, 2023):
Same for me, after logout from iOS app it's working thanks for this feature :)
@BlackDex commented on GitHub (Sep 1, 2023):
I have retested this, and indeed, it seems to work after (again fully cleaning everything or uninstall/re-install the app). Simple logout and login didn't worked, not even with a restart of the phone.
So i had to fully clear all data, and that worked.
@stefan0xC, if we are able to send a nice message, that would be nice, but i'm not sure if that will reach all the stable version users as of now hehe.
We could however create a wiki page maybe which explains these quirks?
@stefan0xC commented on GitHub (Sep 1, 2023):
@martinjgrunwald @BlackDex Does it still work after rebooting the device? I've not tested this very extensively but I could reproduce this issue earlier by simply rebooting my Android device. Not sure if this is dependend on some expiration date but if it does not work after a reboot I would not dismiss the issue prematurely.
@martinjgrunwald commented on GitHub (Sep 1, 2023):
@stefan0xC You are right, after a reboot of my iPhone the issue re-appears
@BlackDex commented on GitHub (Sep 1, 2023):
Ok, i tested it again, and it breaks again indeed.
We probably want to test this with an official Bitwarden environment to, and see what happens.
Because, if that is the case, it's a bug in the client.
@catfluoride commented on GitHub (Sep 1, 2023):
It works like this for me in Android as well. Thanks!
@BlackDex commented on GitHub (Sep 1, 2023):
@stefan0xC the
masterPasswordHashis optional.So, we need to change the code to support
Option<String>and adjust the databases to allownull.I just quickly tested this locally and that works just fine.
@BlackDex commented on GitHub (Sep 1, 2023):
PR Created which should fix this issue #3831