mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-03-11 17:41:29 -05:00
Cannot delete entries from browser extension or client applications #4355
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sgissi on GitHub (Jun 1, 2020).
Subject of the issue
Cannot delete entries from browser extension or client applications. Works fine from web vault.
Your environment
Steps to reproduce
Run bitwarden_rs server, create one entry, connect using client or web extension and delete the entry. Entry will remain, server will show a 404 error:
[2020-06-01 21:33:53][request][INFO] PUT /api/ciphers//delete
[2020-06-01 21:33:53][response][INFO] 404 Not Found
When using the Web Vault it uses the DELETE verb:
[2020-06-01 22:24:55][request][INFO] DELETE /api/ciphers/
[2020-06-01 22:24:55][response][INFO] DELETE /api/ciphers/ (delete_cipher) => 200 OK
Relevant commit
The root of the issue is that the path "put /ciphers/<uuid>/delete" is not recognized by the server. This commit fixes the issue while implementing soft delete. If that commit isn't ready for release, a simple fix is to add the relevant functions in src/api/core/ciphers.rs (plus adding them into routes() of course):
Is it possible to get a 2.14.3 released with either fix? Happy to submit PR against 2.14.2 if needed.
@sgissi commented on GitHub (Jun 1, 2020):
Forgot to mention, 1.18 was released a few days ago, all my clients got updated automatically and created the issue: https://github.com/bitwarden/desktop/releases/tag/v1.18.0
@BlackDex commented on GitHub (Jun 2, 2020):
I just did a quick test, but i do not have any issues with this either with the Firefox Extension or the Desktop application.
What i do find strange is that you have an extra / there, which seem to cause an issue.
@dani-garcia commented on GitHub (Jun 2, 2020):
He's using the numbered releases, and the latest release didn't contain the soft delete functionality, I've made a new release now containing that and the new admin page, it will still take some hours to build still.
The missing id in that request is weird, maybe @sgissi just censored it himself though.
@sgissi commented on GitHub (Jun 2, 2020):
Thank you both. Actually I replaced with <redacted> but Github didn't like the <> signs and removed it, my mistake. In retrospect, it is really just UUID, not a secret, no need to redact really. I'm using numbered releases indeed, I'll test the new images and let you know.
@sgissi commented on GitHub (Jun 3, 2020):
Just tested the new release and it worked great out of the box, thanks a lot!