mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-08-28 22:32:18 -05:00
Configured email disable enable resets email settings. #387
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/vaultwarden#387
Reference in New Issue
Block a user
Originally created by @mannp on GitHub (Aug 26, 2019).
Previously working email seems to now be causing me problems.
Issue is, why reset the whole email config when selecting disable/enable?
I would have expected my existing settings to remain but just be disabled.
Or a warning to a user that their current settings will be lost, so save them elsewhere :)
@dani-garcia commented on GitHub (Aug 27, 2019):
Now that you mention it yeah it doesn't make much sense to delete the disabled fields I'm not sure why I chose to do that. We could change that easy but we'll also need to make sure that the settings respect the master toggle, I'm pretty sure the mail settings do, but others like the yubico and duo might not.
@mannp commented on GitHub (Aug 27, 2019):
I am sure there was a good reason at the time for that approach :)
Not entirely sure what the master toggle is and I don't use yubico or duo yet, but can understand why you want consistency.
@lorenzschmid commented on GitHub (Aug 30, 2019):
Could you please elaborate on which settings exactly changed and how one can revert this?
I'm not sure if my issue is related but since recently I receive the error message "Error building email. invalid email address" when trying to log in. This happens even on previously working (and still active) accounts. Even the admin account is affected.
@mannp commented on GitHub (Aug 30, 2019):
All settings get deleted when you.toggle enable / disable.
@lorenzschmid commented on GitHub (Aug 30, 2019):
Thanks for the quick reply. Which settings do you mean? And which toggle are you talking about?
@mannp commented on GitHub (Aug 30, 2019):
Admin panel /admin.. email settings has an option to enable or disable all your email settings.
@lorenzschmid commented on GitHub (Aug 30, 2019):
Thanks a lot. I guess in this case my issue is not related.
@dani-garcia commented on GitHub (Aug 31, 2019):
@mannp In the latest commit, disabling the toggle won't delete the existing values anymore.
@lorenzschmid If you are receving that error while logging in, it's because we can't send the new device login email because apparently the mail library doesn't think the email format is valid, does the email address have any weird characters? You can make the server ignore any errors sending the login email seting
REQUIRE_DEVICE_EMAIL=false@vplme commented on GitHub (Aug 31, 2019):
I think
REQUIRE_DEVICE_EMAIL=falsewill ignore any email errors while logging in which is the default. Unless I've made a mistake somewhere.@dani-garcia commented on GitHub (Aug 31, 2019):
Oops yeah my mistake, edited the comment.
@mannp commented on GitHub (Aug 31, 2019):
Thanks @dani-garcia for the quick fix :)
Is REQUIRE_DEVICE_EMAIL=false default as I don't specifically set it and disabling email allowed me to login again, as well as removing 2FA too.... I didn't change REQUIRE_DEVICE_EMAIL at all.
@MagicFab commented on GitHub (Dec 17, 2019):
Has this been fixed in the current version ?
@dani-garcia commented on GitHub (May 13, 2020):
This should be fixed yes.