PUT /api/ciphers/share not implemented #3694

New Issue

Closed

opened 2026-03-07 19:04:31 -06:00 by GiteaMirror · 10 comments

GiteaMirror commented 2026-03-07 19:04:31 -06:00

Owner

Copy Link

Originally created by @mprasil on GitHub (Jul 21, 2018).

New vault (#93) calls PUT on /api/ciphers/share to "Share selected" ciphers. This functionality wasn't present in the previous vault so implementation will be a bit more involved, but should be pretty similar to "move selected".

(also woohoo! 100th issue 😄)

Originally created by @mprasil on GitHub (Jul 21, 2018). New vault (#93) calls `PUT` on `/api/ciphers/share` to "Share selected" ciphers. This functionality wasn't present in the previous vault so implementation will be a bit more involved, but should be pretty similar to "move selected". (also woohoo! 100th issue :smile:)

GiteaMirror added the good first issuebugfuture Vault labels 2026-03-07 19:04:31 -06:00

GiteaMirror closed this issue 2026-03-07 19:04:31 -06:00

GiteaMirror commented 2026-03-07 19:04:32 -06:00

Author

Owner

Copy Link

@tgturner commented on GitHub (Jul 26, 2018):

I would love to take a look at this one!

@tgturner commented on GitHub (Jul 26, 2018): I would love to take a look at this one!

GiteaMirror commented 2026-03-07 19:04:33 -06:00

Author

Owner

Copy Link

@mprasil commented on GitHub (Jul 26, 2018):

Go for it and don't hesitate to ask for help.

@mprasil commented on GitHub (Jul 26, 2018): Go for it and don't hesitate to ask for help.

GiteaMirror commented 2026-03-07 19:04:34 -06:00

Author

Owner

Copy Link

@tgturner commented on GitHub (Jul 26, 2018):

Thanks! I'll take a look at it this evening.

@tgturner commented on GitHub (Jul 26, 2018): Thanks! I'll take a look at it this evening.

GiteaMirror commented 2026-03-07 19:04:34 -06:00

Author

Owner

Copy Link

@krankur commented on GitHub (Aug 1, 2018):

I guess we need to add an organization in order to test the "Share" functionality, but I am not able to figure out how to add an organization? I tried uploading a random JSON file as the license file but I am getting a 401 error. Can someone please guide me on this?

@krankur commented on GitHub (Aug 1, 2018): I guess we need to add an organization in order to test the "Share" functionality, but I am not able to figure out how to add an organization? I tried uploading a random JSON file as the license file but I am getting a 401 error. Can someone please guide me on this?

GiteaMirror commented 2026-03-07 19:04:35 -06:00

Author

Owner

Copy Link

@mprasil commented on GitHub (Aug 1, 2018):

Hi, there's no licence required - just create free organization (the first option) and it should have all features after that.

@mprasil commented on GitHub (Aug 1, 2018): Hi, there's no licence required - just create free organization (the first option) and it should have all features after that.

GiteaMirror commented 2026-03-07 19:04:35 -06:00

Author

Owner

Copy Link

@dani-garcia commented on GitHub (Aug 1, 2018):

I think that happens in the self hosted version (when you build with npm run dist:selfhost)

It should work if you build the normal version (with npm run dist)

@dani-garcia commented on GitHub (Aug 1, 2018): I think that happens in the self hosted version (when you build with npm run dist:selfhost) It should work if you build the normal version (with npm run dist)

GiteaMirror commented 2026-03-07 19:04:37 -06:00

Author

Owner

Copy Link

@mprasil commented on GitHub (Aug 1, 2018):

@dani-garcia I submitted #109 to merge recent changes from master. We should do this before @krankur touches the sharing API as there were some major changes and will be pain to merge later.

@mprasil commented on GitHub (Aug 1, 2018): @dani-garcia I submitted #109 to merge recent changes from master. We should do this before @krankur touches the sharing API as there were some major changes and will be pain to merge later.

GiteaMirror commented 2026-03-07 19:04:37 -06:00

Author

Owner

Copy Link

@mprasil commented on GitHub (Aug 1, 2018):

Thanks for merging it. @krankur make sure you're working with latest beta code.

@mprasil commented on GitHub (Aug 1, 2018): Thanks for merging it. @krankur make sure you're working with latest beta code.

GiteaMirror commented 2026-03-07 19:04:38 -06:00

Author

Owner

Copy Link

@krankur commented on GitHub (Aug 1, 2018):

@mprasil Will do. Thanks for the heads up.

@krankur commented on GitHub (Aug 1, 2018): @mprasil Will do. Thanks for the heads up.

GiteaMirror commented 2026-03-07 19:04:40 -06:00

Author

Owner

Copy Link

@mprasil commented on GitHub (Aug 9, 2018):

I think this was resolved in #116

@mprasil commented on GitHub (Aug 9, 2018): I think this was resolved in #116

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label bug future Vault good first issue

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#3694