github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-08-24 23:22:58 -05:00
Code Issues 534 Packages Projects Releases 86 Wiki Activity

get_org_collection_detail() errors with "Collection not found" when User isn't directly assigned to collection #3647

New Issue
Closed
opened 2026-03-07 19:01:18 -06:00 by GiteaMirror · 1 comment
GiteaMirror commented 2026-03-07 19:01:18 -06:00
Owner
Copy Link
Copy Source

Originally created by @mprasil on GitHub (May 19, 2018).

The function doesn't work for UserOrganization with access_all, for Admin or Owner that doesn't have direct CollectionUser mapping.

This is because we only use Collection::find_by_uuid_and_user() in the handler, but the above users don't necessarily need to have access allowed for specific Collection as they can generally access any Collection within Organization. We need to check whether that isn't the case before returning error.

Originally created by @mprasil on GitHub (May 19, 2018). The function doesn't work for `UserOrganization` with `access_all`, for `Admin` or `Owner` that doesn't have direct `CollectionUser` mapping. This is because we only use `Collection::find_by_uuid_and_user()` in the handler, but the above users don't necessarily need to have access allowed for specific `Collection` as they can generally access any `Collection` within `Organization`. We need to check whether that isn't the case before returning error.
GiteaMirror commented 2026-03-07 19:01:19 -06:00
Author
Owner
Copy Link
Copy Source

@dani-garcia commented on GitHub (May 21, 2018):

This should be fixed by your PR #28 so I'm closing it. Thanks!

@dani-garcia commented on GitHub (May 21, 2018): This should be fixed by your PR #28 so I'm closing it. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#3647