Implements the ability to store passkeys in the vault
How to test
Checkout this branch, then install dependencies with npm i (npm ci didn't worked, where npm i somehow worked in my case)
Enable feature flag for the extension. As I didn't figured out how to do this properly, I changed the values there and there to make them always return true
Follow the docs to build and install the modified extension in your browser (I installed it in a custom profile)
Go to a website supporting passkeys. I used passkeys.io, and also tested against webauthn.io but any website supporting webauthn should actually work, then register your key
Upstream PR: bitwarden/server#2679
Tested on Brave 1.54.65 Chromium: 114.0.5735.133 (Official build) nightly (64 bits)
The feature isn't released yet, but there shouldn't be any big changes as Vaultwarden doesn't type the properties of ciphers the way upstream server does
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3593
**Author:** [@GeekCornerGH](https://github.com/GeekCornerGH)
**Created:** 6/19/2023
**Status:** ✅ Merged
**Merged:** 6/22/2023
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `feature/store-passkeys-in-the-vault`
---
### 📝 Commits (1)
- [`1074315`](https://github.com/dani-garcia/vaultwarden/commit/1074315a872ee5d5cab808144596fd996bc50f36) feat: Support for storing passkeys in the vault
### 📊 Changes
**2 files changed** (+8 additions, -2 deletions)
<details>
<summary>View changed files</summary>
📝 `src/api/core/ciphers.rs` (+4 -1)
📝 `src/db/models/cipher.rs` (+4 -1)
</details>
### 📄 Description
# Implements the ability to store passkeys in the vault
## How to test
1. Checkout [this branch](https://github.com/bitwarden/server/tree/EC-598-beeep-properly-store-passkeys-in-bitwarden), then install dependencies with `npm i` (`npm ci` didn't worked, where `npm i` somehow worked in my case)
2. Enable feature flag for the extension. As I didn't figured out how to do this properly, I changed the values [there](https://github.com/bitwarden/clients/pull/4715/files#diff-ee9271bfbbddd589f955418cf1fc8a360ea76819afe2400d96d2f8a79dc3dd6dR41-R43) and [there](https://github.com/bitwarden/clients/pull/4715/files#diff-ee9271bfbbddd589f955418cf1fc8a360ea76819afe2400d96d2f8a79dc3dd6dR194-R196) to make them always return true
3. Follow the [docs](https://contributing.bitwarden.com/getting-started/clients/browser/#build-instructions) to build and install the modified extension in your browser (I installed it in a custom profile)
4. Go to a website supporting passkeys. I used [passkeys.io](https://passkeys.io), and also tested against [webauthn.io](https://webauthn.io) but any website supporting webauthn should actually work, then register your key
## Demo
https://github.com/dani-garcia/vaultwarden/assets/45696571/4c5bbfd6-3302-4ce2-9a2f-146e5653ce1b
## Notes
Upstream PR: bitwarden/server#2679
Tested on `Brave 1.54.65 Chromium: 114.0.5735.133 (Official build) nightly (64 bits) `
The feature isn't released yet, but there shouldn't be any big changes as Vaultwarden doesn't type the properties of ciphers the way upstream server does
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/3593
Author: @GeekCornerGH
Created: 6/19/2023
Status: ✅ Merged
Merged: 6/22/2023
Merged by: @dani-garcia
Base:
main← Head:feature/store-passkeys-in-the-vault📝 Commits (1)
1074315feat: Support for storing passkeys in the vault📊 Changes
2 files changed (+8 additions, -2 deletions)
View changed files
📝
src/api/core/ciphers.rs(+4 -1)📝
src/db/models/cipher.rs(+4 -1)📄 Description
Implements the ability to store passkeys in the vault
How to test
npm i(npm cididn't worked, wherenpm isomehow worked in my case)Demo
https://github.com/dani-garcia/vaultwarden/assets/45696571/4c5bbfd6-3302-4ce2-9a2f-146e5653ce1b
Notes
Upstream PR: bitwarden/server#2679
Tested on
Brave 1.54.65 Chromium: 114.0.5735.133 (Official build) nightly (64 bits)The feature isn't released yet, but there shouldn't be any big changes as Vaultwarden doesn't type the properties of ciphers the way upstream server does
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.