[GH-ISSUE #4144] Remove post macro from api::core::emergency_access::post_emergency_access or add to routes! #34749

New Issue

Closed

opened 2026-07-13 19:28:08 -05:00 by GiteaMirror · 1 comment

GiteaMirror commented 2026-07-13 19:28:08 -05:00

Owner

Copy Link

Copy Source

Originally created by @zacknewman on GitHub (Dec 7, 2023).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/4144

Discussed in https://github.com/dani-garcia/vaultwarden/discussions/4076

^{Originally posted by zacknewman November 16, 2023}
api::core::emergency_access::post_emergency_access is only ever used once in put_emergency_access, and the Route is not added by routes! in routes. Three fixes are:

• add the Route via routes! in routes.
• Remove the post macro.
• Remove the function altogether and integrate its body into put_emergency_access.

Originally created by @zacknewman on GitHub (Dec 7, 2023). Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/4144 ### Discussed in https://github.com/dani-garcia/vaultwarden/discussions/4076 <div type='discussions-op-text'> ^{Originally posted by **zacknewman** November 16, 2023} [`api::core::emergency_access::post_emergency_access`](https://github.com/dani-garcia/vaultwarden/blob/main/src/api/core/emergency_access.rs#L101) is only ever used once in `put_emergency_access`, and the `Route` is not added by `routes!` in `routes`. Three fixes are: * add the `Route` via `routes!` in `routes`. * Remove the `post` macro. * Remove the function altogether and integrate its body into `put_emergency_access`.</div>

GiteaMirror closed this issue 2026-07-13 19:28:08 -05:00

GiteaMirror commented 2026-07-13 19:28:08 -05:00

Author

Owner

Copy Link

Copy Source

@zacknewman commented on GitHub (Dec 7, 2023):

Based on the most recent PR from @BlackDex, I think this got overlooked due to it being a Discussion and not Issue.

<!-- gh-comment-id:1843931889 --> @zacknewman commented on GitHub (Dec 7, 2023): Based on the most recent [PR](https://github.com/dani-garcia/vaultwarden/pull/4143) from @BlackDex, I think this got overlooked due to it being a Discussion and not Issue.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

v2-registration

revert-7033-patch-1

cached-config-operations

test_dylint

1.37.2

1.37.1

1.37.0

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

GiteaMirror ninjasurge (Kaehlen Rog)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#34749