mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-08-27 05:35:03 -05:00
[GH-ISSUE #3249] Read Only rights issue with Groups generating trash entry on user vault #34461
Reference in New Issue
Block a user
Originally created by @Misterbabou on GitHub (Feb 16, 2023).
Original GitHub issue: https://github.com/dani-garcia/vaultwarden/issues/3249
Subject of the issue
Read Only rights issue with Groups generating trash entry on user vault (with the groups beta feature enabled).
Deployment environment
Install method: Custom Built with docker with last #3108 Merge (same issue with docker vaultwarden/server:testing )
Clients used: web vault
Reverse proxy and version: No
MySQL/MariaDB or PostgreSQL version: MariaDB 10.10.2 , Same issue with Sqlite
Environment settings:
Steps to reproduce
4.1. Give permission of that collection "C" to the group "G" with Read Only access
4.2. Assign the user "U" to the group "G"
4.3. Make sure that the user "U" does not have direct permission on the collection "C". In other words: the permission should be configured via the group only!
5.1. Add a new entry to the collection "C", "C" is shown even if the group is in RO access
5.2 Save the entry -> Error message
No rights to modify the collection5.3 A blanck entry is created automatically with nothing inside in the user "U" vault (see screenshot)
Expected behaviour
User can't select the collection "C" with rights read only (assign by a group)
This is already working for rights directly applied on user (user can't select collection with read only access)
Actual behaviour
User "U" can select a collection "C" with rights read only (assign by a group) and create automatically a trash entry in his personnal vault
Troubleshooting data
Trash entry created :

Collection available list when creating entry with rights applied on groups

Collection available list when creating entry with right applied directly to user (Expected behaviour with group)

@Misterbabou commented on GitHub (Feb 16, 2023):
I modified Steps to reproduce to explain the steps better
I made new tests with those changing variable :
1 - image: vaultwarden/server:testing (last available), and MariaDB 10.10.2
2- image: vaultwarden/server:testing (last available) and Sqlite
I have still the same issue with those additional tests.