[PR #4485] [CLOSED] update the webauthn crate #3304

New Issue

GiteaMirror · 2025-11-07T08:08:33-06:00

GiteaMirror commented

2025-11-07 08:08:33 -06:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4485
Author: @stefan0xC
Created: 4/9/2024
Status: ❌ Closed

Base: main ← Head: webauthn-update

📝 Commits (1)

6c3109d update webauthn-rs crate

📊 Changes

7 files changed (+307 additions, -189 deletions)

View changed files

📝 Cargo.lock (+252 -34)
📝 Cargo.toml (+2 -1)
📝 src/api/core/two_factor/webauthn.rs (+20 -142)
📝 src/config.rs (+18 -0)
📝 src/db/models/two_factor.rs (+11 -10)
📝 src/error.rs (+3 -1)
📝 src/main.rs (+1 -1)

📄 Description

I have been working on updating the webauthn_rs crate (as basis to implement passkey support).

The feature danger-allow-state-serialisation is used to serialize the state into the database, which should be fine according to: https://docs.rs/webauthn-rs/0.4.8/webauthn_rs/index.html#allow-serialising-registration-and-authentication-state

I've also decided to remove the u2f migration because it would have required the use of the more low level, protocol interactions provided by the webauthn_core_rs crate, so I guess this could be considered a breaking change? (If this is deemed necessary I can revert the removal, I mainly did it because upgrading the crate was tedious enough.)

I could not actually test the changes because I don't have a security key myself. And therefore I also don't know if it addresses the issues raised in https://github.com/dani-garcia/vaultwarden/issues/4196 (but I think it should be easier with the use of the Safe API?). So someone else definitely needs to test it and/or take over this PR.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4485 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 4/9/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `webauthn-update` --- ### 📝 Commits (1) - [`6c3109d`](https://github.com/dani-garcia/vaultwarden/commit/6c3109d517a5205cc2a182f60a8082e2c725d727) update webauthn-rs crate ### 📊 Changes **7 files changed** (+307 additions, -189 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+252 -34) 📝 `Cargo.toml` (+2 -1) 📝 `src/api/core/two_factor/webauthn.rs` (+20 -142) 📝 `src/config.rs` (+18 -0) 📝 `src/db/models/two_factor.rs` (+11 -10) 📝 `src/error.rs` (+3 -1) 📝 `src/main.rs` (+1 -1) </details> ### 📄 Description I have been working on updating the `webauthn_rs` crate (as basis to implement passkey support). The feature `danger-allow-state-serialisation` is used to serialize the state into the database, which should be fine according to: https://docs.rs/webauthn-rs/0.4.8/webauthn_rs/index.html#allow-serialising-registration-and-authentication-state I've also decided to remove the u2f migration because it would have required the use of the more low level, protocol interactions provided by the [webauthn_core_rs](https://docs.rs/webauthn-rs-core/latest/webauthn_rs_core/) crate, so I guess this could be considered a breaking change? (If this is deemed necessary I can revert the removal, I mainly did it because upgrading the crate was tedious enough.) I could not actually test the changes because I don't have a security key myself. And therefore I also don't know if it addresses the issues raised in https://github.com/dani-garcia/vaultwarden/issues/4196 (but I think it should be easier with the use of the Safe API?). So someone else definitely needs to test it and/or take over this PR. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-07 08:08:33 -06:00

GiteaMirror closed this issue

2025-11-07 08:08:33 -06:00

GiteaMirror referenced this issue

2026-03-07 19:06:02 -06:00

add support for push notifications on changes #3708

GiteaMirror referenced this issue

2026-03-07 19:08:49 -06:00

[META] Feature Requests #3762

GiteaMirror referenced this issue

2026-03-07 20:18:03 -06:00

Items Taking 15 Seconds to Save with PUSH_ENABLED=true #5248