[PR #7346] 2026.6.0 send support #32950

New Issue

GiteaMirror · 2026-06-20T19:38:58-05:00

GiteaMirror commented

2026-06-20 19:38:58 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/7346
Author: @Timshel
Created: 6/17/2026
Status: 🔄 Open

Base: main ← Head: fix/send

📝 Commits (2)

64d943b 2026.6.0 send support
8450af2 Prevent creating and editing a Send with email verification

📊 Changes

6 files changed (+351 additions, -18 deletions)

View changed files

➕ playwright/tests/send.spec.ts (+72 -0)
📝 src/api/core/sends.rs (+54 -11)
📝 src/api/identity.rs (+19 -2)
📝 src/auth.rs (+15 -0)
➕ src/auth/send.rs (+172 -0)
📝 src/error.rs (+19 -5)

📄 Description

With 2026.6.0 the client now start by requiring an access_token.

Some remarks:

Added auth/send.rs since I though that auth.rs was already long enough.
Added the silent property to the Error to be use ErrorKind::Json without logging the error.
Probably could be injected in some place like the Error::empty but wanted to keep modifications to a minimum.

While adding another set of optional values to ConnectData I wondered if it could be converted to an Enum with a value for each grant_type ? I think it would be cleaner, but maybe I'm missing something ?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/7346 **Author:** [@Timshel](https://github.com/Timshel) **Created:** 6/17/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/send` --- ### 📝 Commits (2) - [`64d943b`](https://github.com/dani-garcia/vaultwarden/commit/64d943b625a5087a4c063e64079ad8905210fc9a) 2026.6.0 send support - [`8450af2`](https://github.com/dani-garcia/vaultwarden/commit/8450af2094c4c1d83005fdc822b196a95da0d1ff) Prevent creating and editing a Send with email verification ### 📊 Changes **6 files changed** (+351 additions, -18 deletions) <details> <summary>View changed files</summary> ➕ `playwright/tests/send.spec.ts` (+72 -0) 📝 `src/api/core/sends.rs` (+54 -11) 📝 `src/api/identity.rs` (+19 -2) 📝 `src/auth.rs` (+15 -0) ➕ `src/auth/send.rs` (+172 -0) 📝 `src/error.rs` (+19 -5) </details> ### 📄 Description With `2026.6.0` the client now start by requiring an access_token. Some remarks: - Added `auth/send.rs` since I though that `auth.rs` was already long enough. - Added the `silent` property to the `Error` to be use `ErrorKind::Json` without logging the error. Probably could be injected in some place like the `Error::empty` but wanted to keep modifications to a minimum. While adding another set of optional values to `ConnectData` I wondered if it could be converted to an `Enum` with a value for each `grant_type` ? I think it would be cleaner, but maybe I'm missing something ? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-06-20 19:38:58 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#32950