Without the SSO logic it's not the most useful still :
Add an expiration on the refresh_token (work like an idle timer reset when a new access_token is generated).
Store the information of the AuthMethod in the token (Password ...).
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4371
**Author:** [@Timshel](https://github.com/Timshel)
**Created:** 2/20/2024
**Status:** ❌ Closed
**Base:** `main` ← **Head:** `feature/jwt_refresh`
---
### 📝 Commits (2)
- [`7523e00`](https://github.com/dani-garcia/vaultwarden/commit/7523e00fbc0defd3bddbb7b7546387c640eaddba) JWT Refresh Token
- [`2467e91`](https://github.com/dani-garcia/vaultwarden/commit/2467e9178a403a5b06cea4d80024578b735401cd) Improve error message
### 📊 Changes
**5 files changed** (+257 additions, -111 deletions)
<details>
<summary>View changed files</summary>
📝 `src/api/identity.rs` (+51 -51)
📝 `src/api/mod.rs` (+1 -1)
📝 `src/auth.rs` (+198 -1)
📝 `src/db/models/device.rs` (+3 -58)
📝 `src/error.rs` (+4 -0)
</details>
### 📄 Description
To facilitate review decided to move out the switch to a JWT refresh_token from the sso PR https://github.com/dani-garcia/vaultwarden/pull/3899.
Without the SSO logic it's not the most useful still :
- Add an expiration on the `refresh_token` (work like an idle timer reset when a new access_token is generated).
- Store the information of the `AuthMethod` in the token (`Password` ...).
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/4371
Author: @Timshel
Created: 2/20/2024
Status: ❌ Closed
Base:
main← Head:feature/jwt_refresh📝 Commits (2)
7523e00JWT Refresh Token2467e91Improve error message📊 Changes
5 files changed (+257 additions, -111 deletions)
View changed files
📝
src/api/identity.rs(+51 -51)📝
src/api/mod.rs(+1 -1)📝
src/auth.rs(+198 -1)📝
src/db/models/device.rs(+3 -58)📝
src/error.rs(+4 -0)📄 Description
To facilitate review decided to move out the switch to a JWT refresh_token from the sso PR https://github.com/dani-garcia/vaultwarden/pull/3899.
Without the SSO logic it's not the most useful still :
refresh_token(work like an idle timer reset when a new access_token is generated).AuthMethodin the token (Password...).🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.