[PR #4860] [MERGED] Fix manager in web-vault v2024.6.2 for collections #32535

Closed
opened 2026-06-20 19:20:40 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4860
Author: @BlackDex
Created: 8/14/2024
Status: Merged
Merged: 8/15/2024
Merged by: @dani-garcia

Base: mainHead: fix-manager-role


📝 Commits (1)

  • 595a809 Fix manager in web-vault v2024.6.2 for collections

📊 Changes

4 files changed (+85 additions, -31 deletions)

View changed files

📝 src/api/core/organizations.rs (+6 -5)
📝 src/db/models/collection.rs (+26 -8)
📝 src/db/models/group.rs (+7 -9)
📝 src/db/models/organization.rs (+46 -9)

📄 Description

The web-vault v2024.6.2 we use needs some extra information to allow managers to actually be able to manage collections.

The v2024.6.2 web-vault has somewhat of a mixture of the newer roles and older manager roles. To at least fix this for the web-vault we bundle these changes will make the manager able to manage.

For future web-vaults we would need a lot more changes to be done to fix this in a better way though.

Fixes #4844


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4860 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 8/14/2024 **Status:** ✅ Merged **Merged:** 8/15/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `fix-manager-role` --- ### 📝 Commits (1) - [`595a809`](https://github.com/dani-garcia/vaultwarden/commit/595a809ce1e6096ce3072178f85985c8f77005e8) Fix manager in web-vault v2024.6.2 for collections ### 📊 Changes **4 files changed** (+85 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/organizations.rs` (+6 -5) 📝 `src/db/models/collection.rs` (+26 -8) 📝 `src/db/models/group.rs` (+7 -9) 📝 `src/db/models/organization.rs` (+46 -9) </details> ### 📄 Description The web-vault v2024.6.2 we use needs some extra information to allow managers to actually be able to manage collections. The v2024.6.2 web-vault has somewhat of a mixture of the newer roles and older manager roles. To at least fix this for the web-vault we bundle these changes will make the manager able to manage. For future web-vaults we would need a lot more changes to be done to fix this in a better way though. Fixes #4844 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-20 19:20:40 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#32535