Added an option to enable smtp debugging via SMTP_DEBUG. This will trigger a trace of the smtp commands sent/received to/from the mail server. Useful when troubleshooting.
Added two options to ignore invalid certificates which either do not match at all, or only doesn't match the hostname. ( fixes#1077 )
Added Message-ID Header, which triggered spamfilters when absent. ( fixes#1207 )
Updated lettre to the latest alpha.4 version.
Fixed plain/text email format
plain/text emails should not contain html elements like
etc..
This triggers some spamfilters and increases the spam score.
Also added the github link into the text only emails since this also triggers spamfilters to increase the score since the url/link count is different between the multipart messages.
Tested by using https://www.mail-tester.com/ to validate the spamscore. (Including the missing Message-ID Header mentioned above)
Updated admin settings page.
Added check if settings are changed but not saved when sending test email.
Added some styling to emphasize some risks settings.
Fixed alignment of elements when the label has multiple lines.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1229
**Author:** [@BlackDex](https://github.com/BlackDex)
**Created:** 11/18/2020
**Status:** ✅ Merged
**Merged:** 11/18/2020
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `master` ← **Head:** `email-fixes`
---
### 📝 Commits (3)
- [`58a9285`](https://github.com/dani-garcia/vaultwarden/commit/58a928547d2f9ef99817f475da5cf65e461d98ea) Updated admin settings page.
- [`3fed323`](https://github.com/dani-garcia/vaultwarden/commit/3fed323385356c429e4e40030bd316047d27f5a1) Fixed plain/text email format
- [`6faaeaa`](https://github.com/dani-garcia/vaultwarden/commit/6faaeaae6649ddfa9a1b4b424a27e6792b1f90b3) Updated email processing.
### 📊 Changes
**20 files changed** (+237 additions, -148 deletions)
<details>
<summary>View changed files</summary>
📝 `.env.template` (+19 -3)
📝 `Cargo.lock` (+42 -30)
📝 `Cargo.toml` (+1 -1)
📝 `src/config.rs` (+18 -12)
📝 `src/mail.rs` (+22 -9)
📝 `src/main.rs` (+10 -0)
📝 `src/static/templates/admin/settings.hbs` (+41 -6)
📝 `src/static/templates/email/change_email.hbs` (+6 -4)
📝 `src/static/templates/email/delete_account.hbs` (+8 -10)
📝 `src/static/templates/email/invite_accepted.hbs` (+5 -6)
📝 `src/static/templates/email/invite_confirmed.hbs` (+5 -6)
📝 `src/static/templates/email/new_device_logged_in.hbs` (+8 -10)
📝 `src/static/templates/email/pw_hint_none.hbs` (+4 -1)
📝 `src/static/templates/email/pw_hint_some.hbs` (+6 -3)
📝 `src/static/templates/email/send_org_invite.hbs` (+10 -10)
📝 `src/static/templates/email/smtp_test.hbs` (+6 -6)
📝 `src/static/templates/email/twofactor_email.hbs` (+5 -6)
📝 `src/static/templates/email/verify_email.hbs` (+7 -9)
📝 `src/static/templates/email/welcome.hbs` (+6 -6)
📝 `src/static/templates/email/welcome_must_verify.hbs` (+8 -10)
</details>
### 📄 Description
### Updated email processing.
- Added an option to enable smtp debugging via SMTP_DEBUG. This will trigger a trace of the smtp commands sent/received to/from the mail server. Useful when troubleshooting.
- Added two options to ignore invalid certificates which either do not match at all, or only doesn't match the hostname. ( fixes #1077 )
- Added Message-ID Header, which triggered spamfilters when absent. ( fixes #1207 )
- Updated lettre to the latest alpha.4 version.
### Fixed plain/text email format
plain/text emails should not contain html elements like <p> <a> etc..
This triggers some spamfilters and increases the spam score.
Also added the github link into the text only emails since this also triggers spamfilters to increase the score since the url/link count is different between the multipart messages.
Tested by using https://www.mail-tester.com/ to validate the spamscore. (Including the missing Message-ID Header mentioned above)
### Updated admin settings page.
- Added check if settings are changed but not saved when sending test email.
- Added some styling to emphasize some risks settings.
- Fixed alignment of elements when the label has multiple lines.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/1229
Author: @BlackDex
Created: 11/18/2020
Status: ✅ Merged
Merged: 11/18/2020
Merged by: @dani-garcia
Base:
master← Head:email-fixes📝 Commits (3)
58a9285Updated admin settings page.3fed323Fixed plain/text email format6faaeaaUpdated email processing.📊 Changes
20 files changed (+237 additions, -148 deletions)
View changed files
📝
.env.template(+19 -3)📝
Cargo.lock(+42 -30)📝
Cargo.toml(+1 -1)📝
src/config.rs(+18 -12)📝
src/mail.rs(+22 -9)📝
src/main.rs(+10 -0)📝
src/static/templates/admin/settings.hbs(+41 -6)📝
src/static/templates/email/change_email.hbs(+6 -4)📝
src/static/templates/email/delete_account.hbs(+8 -10)📝
src/static/templates/email/invite_accepted.hbs(+5 -6)📝
src/static/templates/email/invite_confirmed.hbs(+5 -6)📝
src/static/templates/email/new_device_logged_in.hbs(+8 -10)📝
src/static/templates/email/pw_hint_none.hbs(+4 -1)📝
src/static/templates/email/pw_hint_some.hbs(+6 -3)📝
src/static/templates/email/send_org_invite.hbs(+10 -10)📝
src/static/templates/email/smtp_test.hbs(+6 -6)📝
src/static/templates/email/twofactor_email.hbs(+5 -6)📝
src/static/templates/email/verify_email.hbs(+7 -9)📝
src/static/templates/email/welcome.hbs(+6 -6)📝
src/static/templates/email/welcome_must_verify.hbs(+8 -10)📄 Description
Updated email processing.
Fixed plain/text email format
plain/text emails should not contain html elements like
etc..
This triggers some spamfilters and increases the spam score.
Also added the github link into the text only emails since this also triggers spamfilters to increase the score since the url/link count is different between the multipart messages.
Tested by using https://www.mail-tester.com/ to validate the spamscore. (Including the missing Message-ID Header mentioned above)
Updated admin settings page.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.