[PR #370] [MERGED] Added better favicon downloader. #31740

New Issue

Closed

opened 2026-06-20 18:43:05 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-06-20 18:43:05 -05:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/370
Author: @BlackDex
Created: 1/27/2019
Status: ✅ Merged
Merged: 1/27/2019
Merged by: @dani-garcia

Base: master ← Head: favicons

---

📝 Commits (3)

• 9657463 Added better favicon downloader.
• da068a4 Moved function call to get_icon_url to prevent error bubbeling
• 4de16b2 Removed unwrap and added ?

📊 Changes

5 files changed (+304 additions, -10 deletions)

View changed files

📝 Cargo.lock (+124 -0)
📝 Cargo.toml (+5 -0)
📝 src/api/icons.rs (+172 -10)
📝 src/error.rs (+2 -0)
📝 src/main.rs (+1 -0)

📄 Description

Changed the favicon downloader to use the main html page with <link rel="*icon*"> selection.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/370 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 1/27/2019 **Status:** ✅ Merged **Merged:** 1/27/2019 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `favicons` --- ### 📝 Commits (3) - [`9657463`](https://github.com/dani-garcia/vaultwarden/commit/9657463717048519dd3683d2f2add52fa2c91205) Added better favicon downloader. - [`da068a4`](https://github.com/dani-garcia/vaultwarden/commit/da068a43c1fc4c349875d2cdab90a2c41af430c0) Moved function call to get_icon_url to prevent error bubbeling - [`4de16b2`](https://github.com/dani-garcia/vaultwarden/commit/4de16b2d17fd16666045a0d3d7e1ad99fc4df58c) Removed unwrap and added ? ### 📊 Changes **5 files changed** (+304 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+124 -0) 📝 `Cargo.toml` (+5 -0) 📝 `src/api/icons.rs` (+172 -10) 📝 `src/error.rs` (+2 -0) 📝 `src/main.rs` (+1 -0) </details> ### 📄 Description Changed the favicon downloader to use the main html page with `<link rel="*icon*">` selection. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-06-20 18:43:05 -05:00

GiteaMirror closed this issue 2026-06-20 18:43:06 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

v2-registration

revert-7033-patch-1

cached-config-operations

test_dylint

1.37.2

1.37.1

1.37.0

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

GiteaMirror ninjasurge (Kaehlen Rog)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#31740