mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-03-09 04:32:44 -05:00
Invalid Login Error Code #316
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @uchagani on GitHub (Jun 9, 2019).
Is there a reason bitwarden_rs returns a
400instead of a401or403when invalid credentials are entered?@mprasil commented on GitHub (Jun 10, 2019):
I believe upstream API implementation also returns
400or is that not the case?@uchagani commented on GitHub (Jun 10, 2019):
Not sure tbh. I was just trying to use fail2ban at the reverse proxy layer and saw the 400. I just figured a 403 error would be a more accurate error to look for in the logs.
@mprasil commented on GitHub (Jun 10, 2019):
Just checked and upstream does return
400, so we need to do the same for compatibility reasons.I'm going to close this now, feel free to reopen if there are any outstanding questions.