[PR #3167] [MERGED] Fix Javascript issue on non sqlite databases #30849

New Issue

Closed

opened 2026-06-17 10:50:30 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-06-17 10:50:30 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/3167
Author: @BlackDex
Created: 1/24/2023
Status: ✅ Merged
Merged: 2/12/2023
Merged by: @dani-garcia

Base: main ← Head: issue-3166

---

📝 Commits (2)

• c9ed9aa Fix Javascript issue on non sqlite databases
• bc49d1f Merge branch 'main' into issue-3166

📊 Changes

10 files changed (+190 additions, -108 deletions)

View changed files

📝 src/api/web.rs (+2 -2)
📝 src/static/scripts/admin.css (+14 -7)
📝 src/static/scripts/admin.js (+19 -7)
📝 src/static/scripts/admin_diagnostics.js (+15 -7)
📝 src/static/scripts/admin_organizations.js (+21 -5)
📝 src/static/scripts/admin_settings.js (+40 -25)
📝 src/static/scripts/admin_users.js (+58 -33)
📝 src/static/scripts/jquery-3.6.3.slim.js (+8 -9)
📝 src/static/templates/admin/organizations.hbs (+6 -6)
📝 src/static/templates/admin/users.hbs (+7 -7)

📄 Description

When a non sqlite database is used, loading the admin interface fails
because the backup button is not generated.
This PR is solves it by checking if the elements are valid.

Also made some other js/css changes and fixed some eslint errors.
Showing _post errors is better now.

Update jquery to latest version.

Fixes #3166

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/3167 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 1/24/2023 **Status:** ✅ Merged **Merged:** 2/12/2023 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `issue-3166` --- ### 📝 Commits (2) - [`c9ed9aa`](https://github.com/dani-garcia/vaultwarden/commit/c9ed9aa73382adcc37e0c7bf59a06f72c8774281) Fix Javascript issue on non sqlite databases - [`bc49d1f`](https://github.com/dani-garcia/vaultwarden/commit/bc49d1f90da7df9f9f01b6f49cb13fda721343d3) Merge branch 'main' into issue-3166 ### 📊 Changes **10 files changed** (+190 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `src/api/web.rs` (+2 -2) 📝 `src/static/scripts/admin.css` (+14 -7) 📝 `src/static/scripts/admin.js` (+19 -7) 📝 `src/static/scripts/admin_diagnostics.js` (+15 -7) 📝 `src/static/scripts/admin_organizations.js` (+21 -5) 📝 `src/static/scripts/admin_settings.js` (+40 -25) 📝 `src/static/scripts/admin_users.js` (+58 -33) 📝 `src/static/scripts/jquery-3.6.3.slim.js` (+8 -9) 📝 `src/static/templates/admin/organizations.hbs` (+6 -6) 📝 `src/static/templates/admin/users.hbs` (+7 -7) </details> ### 📄 Description When a non sqlite database is used, loading the admin interface fails because the backup button is not generated. This PR is solves it by checking if the elements are valid. Also made some other js/css changes and fixed some eslint errors. Showing `_post` errors is better now. Update jquery to latest version. Fixes #3166 --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-06-17 10:50:30 -05:00

GiteaMirror closed this issue 2026-06-17 10:50:31 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#30849