[PR #2803] [MERGED] v2022.9.2 expects a json response while registering #3016

Closed
opened 2025-11-07 08:01:00 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/2803
Author: @stefan0xC
Created: 10/7/2022
Status: Merged
Merged: 10/9/2022
Merged by: @dani-garcia

Base: mainHead: update-to-v2022.9.2


📝 Commits (3)

  • e50edca v2022.9.2 expects a json response when registering
  • 9132cc4 return CaptchaBypassToken and register object
  • 0a0f620 return "Object" for consistency

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 src/api/core/accounts.rs (+6 -2)

📄 Description

This is a minimal change to make vaultwarden compatible with v2022.9.2 because the web-vault expects a JSON response while registering now. It checks for the existence of a CaptchaBypassToken (see bitwarden/clients#3531) in the response which leads to a syntax error when trying to parse the Empty result.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/2803 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 10/7/2022 **Status:** ✅ Merged **Merged:** 10/9/2022 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `update-to-v2022.9.2` --- ### 📝 Commits (3) - [`e50edca`](https://github.com/dani-garcia/vaultwarden/commit/e50edcadfbfd806bd7c71f87a65c3ce78da91861) v2022.9.2 expects a json response when registering - [`9132cc4`](https://github.com/dani-garcia/vaultwarden/commit/9132cc4a30eff40e81b7e700c7df45b038f7a38a) return CaptchaBypassToken and register object - [`0a0f620`](https://github.com/dani-garcia/vaultwarden/commit/0a0f620d0b7982bd5d57b57fe909c02cb0125b48) return "Object" for consistency ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/accounts.rs` (+6 -2) </details> ### 📄 Description This is a minimal change to make vaultwarden compatible with v2022.9.2 because the web-vault expects a JSON response while registering now. It checks for the existence of a CaptchaBypassToken (see bitwarden/clients#3531) in the response which leads to a syntax error when trying to parse the Empty result. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-07 08:01:00 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#3016