github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-07-17 09:22:30 -05:00
Code Issues 481 Packages Projects Releases 83 Wiki Activity

[PR #1702] [MERGED] Updated icon fetching and crates. #2862

New Issue
Closed
opened 2025-11-07 07:56:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-07 07:56:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1702
Author: @BlackDex
Created: 5/16/2021
Status: ✅ Merged
Merged: 5/16/2021
Merged by: @dani-garcia

Base: main ← Head: icon-updates-plus

📝 Commits (1)

  • f270f2e Updated icon fetching and crates.

📊 Changes

4 files changed (+272 additions, -112 deletions)

View changed files

📝 Cargo.lock (+142 -56)
📝 Cargo.toml (+10 -4)
📝 src/api/icons.rs (+117 -52)
📝 src/main.rs (+3 -0)

📄 Description

  • Updated some crates
  • Updated icon fetching code:
    • Use a cookie jar and set Max-Age to 2 minutes for all cookies
    • Locate the base href tag to fix some locations
    • Changed User-Agent (Helps on some sites to get HTML instead of JS)
    • Reduced HTML code limit from 512KB to 384KB
    • Allow some large icons higer-up in the sort
    • Allow GIF images
    • Ignore cookie_store and hyper::client debug messages

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1702 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 5/16/2021 **Status:** ✅ Merged **Merged:** 5/16/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `icon-updates-plus` --- ### 📝 Commits (1) - [`f270f2e`](https://github.com/dani-garcia/vaultwarden/commit/f270f2ed652459cec2d5251b998eef17a88ea49e) Updated icon fetching and crates. ### 📊 Changes **4 files changed** (+272 additions, -112 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+142 -56) 📝 `Cargo.toml` (+10 -4) 📝 `src/api/icons.rs` (+117 -52) 📝 `src/main.rs` (+3 -0) </details> ### 📄 Description - Updated some crates - Updated icon fetching code: + Use a cookie jar and set Max-Age to 2 minutes for all cookies + Locate the base href tag to fix some locations + Changed User-Agent (Helps on some sites to get HTML instead of JS) + Reduced HTML code limit from 512KB to 384KB + Allow some large icons higer-up in the sort + Allow GIF images + Ignore cookie_store and hyper::client debug messages --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-07 07:56:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#2862
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?