github-starred/vaultwarden
2
0
Fork 0
mirror of https://github.com/dani-garcia/vaultwarden.git synced 2026-05-24 09:03:15 -05:00
Code Issues 307 Packages Projects Releases 83 Wiki Activity

[PR #1487] [MERGED] Send access check fixes #2828

New Issue
Closed
opened 2025-11-07 07:55:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-07 07:55:46 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/1487
Author: @jjlin
Created: 3/15/2021
Status: ✅ Merged
Merged: 3/15/2021
Merged by: @dani-garcia

Base: master ← Head: send

📝 Commits (1)

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 src/api/core/sends.rs (+6 -6)

📄 Description

Adjust checks for max access count, expiration date, and deletion date.
The date checks aren't that important, but the access count check
currently allows one more access than it should.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/1487 **Author:** [@jjlin](https://github.com/jjlin) **Created:** 3/15/2021 **Status:** ✅ Merged **Merged:** 3/15/2021 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `send` --- ### 📝 Commits (1) - [`00d56d7`](https://github.com/dani-garcia/vaultwarden/commit/00d56d7295fc60c3f4d2cc43d2431dce7ed3edd5) Send access check fixes ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/sends.rs` (+6 -6) </details> ### 📄 Description Adjust checks for max access count, expiration date, and deletion date. The date checks aren't that important, but the access count check currently allows one more access than it should. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-07 07:55:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
better for forum
bug
documentation
duplicate
enhancement
future Vault
good first issue
help wanted
low priority
notes
pull-request
Mirrored from GitHub Pull Request
 question
SSO
Third party
troubleshooting
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#2828
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?