[PR #6127] [MERGED] OpenDAL S3 parameter support #27280

New Issue

GiteaMirror · 2026-06-15T14:36:09-05:00

GiteaMirror commented

2026-06-15 14:36:09 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/6127
Author: @txase
Created: 8/3/2025
Status: ✅ Merged
Merged: 5/15/2026
Merged by: @dani-garcia

Base: main ← Head: s3-params

📝 Commits (2)

8ab5f43 deps: upgrade the reqwest stack to 0.13
67429c5 storage: add OpenDAL S3 URI options

📊 Changes

10 files changed (+532 additions, -456 deletions)

View changed files

📝 Cargo.lock (+155 -325)
📝 Cargo.toml (+8 -7)
📝 src/api/core/sends.rs (+1 -1)
📝 src/auth.rs (+2 -6)
📝 src/config.rs (+20 -111)
📝 src/db/models/attachment.rs (+1 -1)
📝 src/db/models/send.rs (+1 -1)
📝 src/main.rs (+10 -0)
📝 src/sso_client.rs (+37 -4)
➕ src/storage.rs (+297 -0)

📄 Description

This change allows s3:// data paths to include additional parameters as querystrings. The default parameters remain optimized for the official AWS S3 service, but any OpenDAL S3 parameters can be set. For example, to override the default true value for enable_virtual_host_style you can set the data config to:

s3://my-bucket?enable_virtual_host_style=false

Boolean parameters can be set to true by simply adding the parameter:

s3://my-bucket?enable_versioning

Fixes #6112

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/6127 **Author:** [@txase](https://github.com/txase) **Created:** 8/3/2025 **Status:** ✅ Merged **Merged:** 5/15/2026 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `s3-params` --- ### 📝 Commits (2) - [`8ab5f43`](https://github.com/dani-garcia/vaultwarden/commit/8ab5f434500a876ee6c72c15a06e316b857d6db2) deps: upgrade the reqwest stack to 0.13 - [`67429c5`](https://github.com/dani-garcia/vaultwarden/commit/67429c55c348aa0ccf6830821a7b4cd0a409cd4d) storage: add OpenDAL S3 URI options ### 📊 Changes **10 files changed** (+532 additions, -456 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+155 -325) 📝 `Cargo.toml` (+8 -7) 📝 `src/api/core/sends.rs` (+1 -1) 📝 `src/auth.rs` (+2 -6) 📝 `src/config.rs` (+20 -111) 📝 `src/db/models/attachment.rs` (+1 -1) 📝 `src/db/models/send.rs` (+1 -1) 📝 `src/main.rs` (+10 -0) 📝 `src/sso_client.rs` (+37 -4) ➕ `src/storage.rs` (+297 -0) </details> ### 📄 Description This change allows s3:// data paths to include additional parameters as querystrings. The default parameters remain optimized for the official AWS S3 service, but any OpenDAL S3 parameters can be set. For example, to override the default `true` value for `enable_virtual_host_style` you can set the data config to: s3://my-bucket?enable_virtual_host_style=false Boolean parameters can be set to `true` by simply adding the parameter: s3://my-bucket?enable_versioning Fixes #6112 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-06-15 14:36:09 -05:00

GiteaMirror closed this issue

2026-06-15 14:36:09 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#27280