On mobile apps (tested with protonmail and K-9 mail) the 2FA email was shifted to the left because of some width style of 600px that was good for other emails but not for this one, this one needed a width of 410px :
before :
after :
before :
after :
Nothing has changed for webmails but of course I haven't tested every mailclient
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/998
**Author:** [@frdescam](https://github.com/frdescam)
**Created:** 5/18/2020
**Status:** ✅ Merged
**Merged:** 5/23/2020
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `master` ← **Head:** `fix_email_templates`
---
### 📝 Commits (2)
- [`8f4a1f4`](https://github.com/dani-garcia/vaultwarden/commit/8f4a1f4fc2c205c4942ea9ecf13890bf4f48f209) fixing bad width in 2FA email template
- [`afaebc6`](https://github.com/dani-garcia/vaultwarden/commit/afaebc6cf359fb77c65bdf80ec07bfa4573709d4) fixing hard coded width email templates
### 📊 Changes
**13 files changed** (+16 additions, -16 deletions)
<details>
<summary>View changed files</summary>
📝 `src/static/templates/email/change_email.html.hbs` (+1 -1)
📝 `src/static/templates/email/delete_account.html.hbs` (+1 -1)
📝 `src/static/templates/email/invite_accepted.html.hbs` (+1 -1)
📝 `src/static/templates/email/invite_confirmed.html.hbs` (+1 -1)
📝 `src/static/templates/email/new_device_logged_in.html.hbs` (+1 -1)
📝 `src/static/templates/email/pw_hint_none.html.hbs` (+1 -1)
📝 `src/static/templates/email/pw_hint_some.html.hbs` (+1 -1)
📝 `src/static/templates/email/send_org_invite.html.hbs` (+1 -1)
📝 `src/static/templates/email/smtp_test.html.hbs` (+1 -1)
📝 `src/static/templates/email/twofactor_email.html.hbs` (+4 -4)
📝 `src/static/templates/email/verify_email.html.hbs` (+1 -1)
📝 `src/static/templates/email/welcome.html.hbs` (+1 -1)
📝 `src/static/templates/email/welcome_must_verify.html.hbs` (+1 -1)
</details>
### 📄 Description
On mobile apps (tested with protonmail and K-9 mail) the 2FA email was shifted to the left because of some width style of 600px that was good for other emails but not for this one, this one needed a width of 410px :
before :
after :
before :
after :
Nothing has changed for webmails but of course I haven't tested every mailclient
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/998
Author: @frdescam
Created: 5/18/2020
Status: ✅ Merged
Merged: 5/23/2020
Merged by: @dani-garcia
Base:
master← Head:fix_email_templates📝 Commits (2)
8f4a1f4fixing bad width in 2FA email templateafaebc6fixing hard coded width email templates📊 Changes
13 files changed (+16 additions, -16 deletions)
View changed files
📝
src/static/templates/email/change_email.html.hbs(+1 -1)📝
src/static/templates/email/delete_account.html.hbs(+1 -1)📝
src/static/templates/email/invite_accepted.html.hbs(+1 -1)📝
src/static/templates/email/invite_confirmed.html.hbs(+1 -1)📝
src/static/templates/email/new_device_logged_in.html.hbs(+1 -1)📝
src/static/templates/email/pw_hint_none.html.hbs(+1 -1)📝
src/static/templates/email/pw_hint_some.html.hbs(+1 -1)📝
src/static/templates/email/send_org_invite.html.hbs(+1 -1)📝
src/static/templates/email/smtp_test.html.hbs(+1 -1)📝
src/static/templates/email/twofactor_email.html.hbs(+4 -4)📝
src/static/templates/email/verify_email.html.hbs(+1 -1)📝
src/static/templates/email/welcome.html.hbs(+1 -1)📝
src/static/templates/email/welcome_must_verify.html.hbs(+1 -1)📄 Description
On mobile apps (tested with protonmail and K-9 mail) the 2FA email was shifted to the left because of some width style of 600px that was good for other emails but not for this one, this one needed a width of 410px :
before :
after :
before :
after :
Nothing has changed for webmails but of course I haven't tested every mailclient
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.