mirror of
https://github.com/dani-garcia/vaultwarden.git
synced 2026-07-17 09:22:30 -05:00
[PR #4845] [CLOSED] Include sqlite3 binaries in Docker images #27073
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/4845
Author: @capi
Created: 8/12/2024
Status: ❌ Closed
Base:
main← Head:add-sqlite3-to-docker-images📝 Commits (1)
ba7659cInclude sqlite3 binaries in Docker images📊 Changes
3 files changed (+8 additions, -4 deletions)
View changed files
📝
docker/Dockerfile.alpine(+2 -1)📝
docker/Dockerfile.debian(+2 -1)📝
docker/Dockerfile.j2(+4 -2)📄 Description
I understand that the runtime docker images are trimmed down for size. Regardless, I think that it makes sense to have the sqlite3 binaries as part of the images because it makes backups way easier without having to resort to other images/containers or having sqlite installed on the docker host.
A cron-driven backup on the Docker host would then just be similar to the following cronjob (assuming a running container named
vaultwarden)If size of the images is more important, I understand, please decline the PR.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.