[PR #864] [MERGED] Do not disable invitations via admin API #2675

New Issue

2025-11-07T07:51:36-06:00

GiteaMirror commented

2025-11-07 07:51:36 -06:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/864
Author: @mprasil
Created: 2/16/2020
Status: ✅ Merged
Merged: 2/16/2020
Merged by: @dani-garcia

Base: master ← Head: admin-invitation

📝 Commits (2)

0a72c4b Do not disable invitations via admin API
0323342 Remove check from Invitation:take()

📊 Changes

2 files changed (+4 additions, -9 deletions)

View changed files

📝 src/api/admin.rs (+0 -4)
📝 src/db/models/user.rs (+4 -5)

📄 Description

This was brought up today:

https://github.com/dani-garcia/bitwarden_rs/issues/752#issuecomment-586715073

I don't think it makes much sense in checking whether admin has the
right to send invitation as admin can change the setting anyway.

Removing the condition allows users to forbid regular users from
inviting new users to server while still preserving the option to do so
via the admin API.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/864 **Author:** [@mprasil](https://github.com/mprasil) **Created:** 2/16/2020 **Status:** ✅ Merged **Merged:** 2/16/2020 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `admin-invitation` --- ### 📝 Commits (2) - [`0a72c4b`](https://github.com/dani-garcia/vaultwarden/commit/0a72c4b6db4e254d7579b8dc3bb6e9e3c067947d) Do not disable invitations via admin API - [`0323342`](https://github.com/dani-garcia/vaultwarden/commit/03233429f4475de558c58707224d1cf72aa28c42) Remove check from Invitation:take() ### 📊 Changes **2 files changed** (+4 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+0 -4) 📝 `src/db/models/user.rs` (+4 -5) </details> ### 📄 Description This was brought up today: https://github.com/dani-garcia/bitwarden_rs/issues/752#issuecomment-586715073 I don't think it makes much sense in checking whether admin has the right to send invitation as admin can change the setting anyway. Removing the condition allows users to forbid regular users from inviting new users to server while still preserving the option to do so via the admin API. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-07 07:51:36 -06:00

GiteaMirror closed this issue