Extend cipher response models to include cipher, cipherMini, cipherDetails, and cipherMiniDetails.
Require a collection when adding a cipher to an organization.
Edit: This PR plus #990fixes#971 (read only collections showing in add/edit cipher and cipher creation in "unassigned collection" when the user should be read only)
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/991
**Author:** [@theycallmesteve](https://github.com/theycallmesteve)
**Created:** 5/8/2020
**Status:** ❌ Closed
**Base:** `master` ← **Head:** `extend_cipher_require_collection`
---
### 📝 Commits (2)
- [`efa07fa`](https://github.com/dani-garcia/vaultwarden/commit/efa07fa91851eca4f08f110c3c028f24939b247a) Extend cipher response models to include cipher, cipherMini, cipherDetails, and cipherMiniDetails
- [`2f6b506`](https://github.com/dani-garcia/vaultwarden/commit/2f6b506710bcdfa2c064455621771278490ecbb8) Require a collection when adding a cipher to an organization
### 📊 Changes
**3 files changed** (+121 additions, -42 deletions)
<details>
<summary>View changed files</summary>
📝 `src/api/core/ciphers.rs` (+49 -19)
📝 `src/api/core/organizations.rs` (+1 -1)
📝 `src/db/models/cipher.rs` (+71 -22)
</details>
### 📄 Description
Extend cipher response models to include cipher, cipherMini, cipherDetails, and cipherMiniDetails.
Require a collection when adding a cipher to an organization.
Edit: This PR plus #990 fixes #971 (read only collections showing in add/edit cipher and cipher creation in "unassigned collection" when the user should be read only)
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/991
Author: @theycallmesteve
Created: 5/8/2020
Status: ❌ Closed
Base:
master← Head:extend_cipher_require_collection📝 Commits (2)
efa07faExtend cipher response models to include cipher, cipherMini, cipherDetails, and cipherMiniDetails2f6b506Require a collection when adding a cipher to an organization📊 Changes
3 files changed (+121 additions, -42 deletions)
View changed files
📝
src/api/core/ciphers.rs(+49 -19)📝
src/api/core/organizations.rs(+1 -1)📝
src/db/models/cipher.rs(+71 -22)📄 Description
Extend cipher response models to include cipher, cipherMini, cipherDetails, and cipherMiniDetails.
Require a collection when adding a cipher to an organization.
Edit: This PR plus #990 fixes #971 (read only collections showing in add/edit cipher and cipher creation in "unassigned collection" when the user should be read only)
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.