[PR #643] [MERGED] Updated icon blacklisting. #2632

New Issue

Closed

opened 2025-11-07 07:49:36 -06:00 by GiteaMirror · 0 comments

GiteaMirror commented 2025-11-07 07:49:36 -06:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/643
Author: @BlackDex
Created: 10/5/2019
Status: ✅ Merged
Merged: 10/5/2019
Merged by: @dani-garcia

Base: master ← Head: icon-security

---

📝 Commits (2)

• 9124d8a Updated icon blacklisting.
• e6b7630 Merge branch 'master' into icon-security

📊 Changes

3 files changed (+45 additions, -11 deletions)

View changed files

📝 src/api/icons.rs (+41 -10)
📝 src/config.rs (+3 -0)
📝 src/main.rs (+1 -1)

📄 Description

• Blacklisting was not effective for redirects and rel href
• Able to blacklist non global IP's like RFC1918, multicast etc...

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/643 **Author:** [@BlackDex](https://github.com/BlackDex) **Created:** 10/5/2019 **Status:** ✅ Merged **Merged:** 10/5/2019 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `icon-security` --- ### 📝 Commits (2) - [`9124d8a`](https://github.com/dani-garcia/vaultwarden/commit/9124d8a3fb236ba7cf0f298d81f59302b9fd8c6e) Updated icon blacklisting. - [`e6b7630`](https://github.com/dani-garcia/vaultwarden/commit/e6b763026e25b57eb342bc90aeced6a856c63681) Merge branch 'master' into icon-security ### 📊 Changes **3 files changed** (+45 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/api/icons.rs` (+41 -10) 📝 `src/config.rs` (+3 -0) 📝 `src/main.rs` (+1 -1) </details> ### 📄 Description - Blacklisting was not effective for redirects and rel href - Able to blacklist non global IP's like RFC1918, multicast etc... --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2025-11-07 07:49:36 -06:00

GiteaMirror closed this issue 2025-11-07 07:49:36 -06:00

GiteaMirror referenced this issue 2025-11-07 08:00:19 -06:00

[PR #2632] [MERGED] Update build workflow for CI #2988

GiteaMirror referenced this issue 2026-03-07 21:04:41 -06:00

[PR #2632] [MERGED] Update build workflow for CI #6765

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

cached-config-operations

test_dylint

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#2632