[PR #7197] [MERGED] sso_auth improvements #26117

New Issue

GiteaMirror · 2026-05-29T05:07:04-05:00

GiteaMirror commented

2026-05-29 05:07:04 -05:00

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/7197
Author: @Timshel
Created: 5/8/2026
Status: ✅ Merged
Merged: 5/16/2026
Merged by: @BlackDex

Base: main ← Head: sso_auth

📝 Commits (1)

1eddcd6 sso_auth improvements

📊 Changes

11 files changed (+59 additions, -48 deletions)

View changed files

➕ migrations/mysql/2026-05-05-120000_sso_auth_error/down.sql (+1 -0)
➕ migrations/mysql/2026-05-05-120000_sso_auth_error/up.sql (+1 -0)
➕ migrations/postgresql/2026-05-05-120000_sso_auth_error/down.sql (+1 -0)
➕ migrations/postgresql/2026-05-05-120000_sso_auth_error/up.sql (+1 -0)
➕ migrations/sqlite/2026-05-05-120000_sso_auth_error/down.sql (+1 -0)
➕ migrations/sqlite/2026-05-05-120000_sso_auth_error/up.sql (+1 -0)
📝 src/api/identity.rs (+19 -23)
📝 src/db/models/mod.rs (+1 -1)
📝 src/db/models/sso_auth.rs (+18 -10)
📝 src/db/schema.rs (+1 -0)
📝 src/sso.rs (+14 -14)

📄 Description

Improve SSO auth flow.

Was a bit lazy with the code_response_error column and stored both error and error_description in it.
Could be written as two columns but preferred to have the Option of the tuple instead of two separate Option.

For mysql deleted the sso_auth table since the code_response contained and whole json serialization and could overflow the new VARCHAR(768) limit (due to the index).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/7197 **Author:** [@Timshel](https://github.com/Timshel) **Created:** 5/8/2026 **Status:** ✅ Merged **Merged:** 5/16/2026 **Merged by:** [@BlackDex](https://github.com/BlackDex) **Base:** `main` ← **Head:** `sso_auth` --- ### 📝 Commits (1) - [`1eddcd6`](https://github.com/dani-garcia/vaultwarden/commit/1eddcd6563a15d5077d9293a7aff716b3752c2d0) sso_auth improvements ### 📊 Changes **11 files changed** (+59 additions, -48 deletions) <details> <summary>View changed files</summary> ➕ `migrations/mysql/2026-05-05-120000_sso_auth_error/down.sql` (+1 -0) ➕ `migrations/mysql/2026-05-05-120000_sso_auth_error/up.sql` (+1 -0) ➕ `migrations/postgresql/2026-05-05-120000_sso_auth_error/down.sql` (+1 -0) ➕ `migrations/postgresql/2026-05-05-120000_sso_auth_error/up.sql` (+1 -0) ➕ `migrations/sqlite/2026-05-05-120000_sso_auth_error/down.sql` (+1 -0) ➕ `migrations/sqlite/2026-05-05-120000_sso_auth_error/up.sql` (+1 -0) 📝 `src/api/identity.rs` (+19 -23) 📝 `src/db/models/mod.rs` (+1 -1) 📝 `src/db/models/sso_auth.rs` (+18 -10) 📝 `src/db/schema.rs` (+1 -0) 📝 `src/sso.rs` (+14 -14) </details> ### 📄 Description Improve SSO auth flow. Was a bit lazy with the `code_response_error` column and stored both `error` and `error_description` in it. Could be written as two columns but preferred to have the `Option` of the tuple instead of two separate `Option`. For `mysql` deleted the `sso_auth` table since the `code_response` contained and whole json serialization and could overflow the new `VARCHAR(768)` limit (due to the index). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-05-29 05:07:04 -05:00

GiteaMirror closed this issue

2026-05-29 05:07:05 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#26117