A possible user disclosure when you invite an user into an organization which already has an account on the same instance. This was because we always returned the user's name. To prevent this, this PR only returns the user's name if the status is accepted or higher, else we will return null. This is the same as Bitwarden does.
Resolves a reported issue.
Also resolved a new nightly reported clippy regarding a regex within a loop.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5110
**Author:** [@BlackDex](https://github.com/BlackDex)
**Created:** 10/19/2024
**Status:** ✅ Merged
**Merged:** 10/19/2024
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `hide-username-on-invite-status`
---
### 📝 Commits (1)
- [`090d77d`](https://github.com/dani-garcia/vaultwarden/commit/090d77d322b591c3f8f8c7c07797a588e053b2bc) Hide user name on invite status
### 📊 Changes
**2 files changed** (+10 additions, -2 deletions)
<details>
<summary>View changed files</summary>
📝 `src/db/models/organization.rs` (+9 -1)
📝 `src/main.rs` (+1 -1)
</details>
### 📄 Description
A possible user disclosure when you invite an user into an organization which already has an account on the same instance. This was because we always returned the user's name. To prevent this, this PR only returns the user's name if the status is accepted or higher, else we will return null. This is the same as Bitwarden does.
Resolves a reported issue.
Also resolved a new `nightly` reported clippy regarding a regex within a loop.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/5110
Author: @BlackDex
Created: 10/19/2024
Status: ✅ Merged
Merged: 10/19/2024
Merged by: @dani-garcia
Base:
main← Head:hide-username-on-invite-status📝 Commits (1)
090d77dHide user name on invite status📊 Changes
2 files changed (+10 additions, -2 deletions)
View changed files
📝
src/db/models/organization.rs(+9 -1)📝
src/main.rs(+1 -1)📄 Description
A possible user disclosure when you invite an user into an organization which already has an account on the same instance. This was because we always returned the user's name. To prevent this, this PR only returns the user's name if the status is accepted or higher, else we will return null. This is the same as Bitwarden does.
Resolves a reported issue.
Also resolved a new
nightlyreported clippy regarding a regex within a loop.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.