[PR #5482] [MERGED] add and use new event types #24492

New Issue

Closed

opened 2026-05-22 01:54:05 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-05-22 01:54:05 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/5482
Author: @stefan0xC
Created: 1/27/2025
Status: ✅ Merged
Merged: 1/28/2025
Merged by: @BlackDex

Base: main ← Head: add-additional-events

---

📝 Commits (5)

• c66935d add additional event_types
• 1b9efc0 use correct event_type when leaving an org
• 32d47fa use correct event type when deleting a user
• 3d6f9cf also correctly log auth requests
• a7ef547 add correct membership info to event log

📊 Changes

5 files changed (+48 additions, -6 deletions)

View changed files

📝 src/api/admin.rs (+1 -1)
📝 src/api/core/accounts.rs (+26 -0)
📝 src/api/core/events.rs (+5 -4)
📝 src/api/core/organizations.rs (+1 -1)
📝 src/db/models/event.rs (+15 -0)

📄 Description

It seems like the web-vault has some additional event types, so I've updated our list accordingly. Most of them are added only for reference (and it seems like the web-vault does not even have support to display all of them correctly at the moment).

I've used the new ones for auth requests and to differentiate between a member leaving an organization

and getting the whole account deleted by an admin (possibly this should also be when it's deleted by yourself?).

Lastly I also changed it so that the membership info is also stored in the log_user_event for the found organizations, so the link to the member id won't show up as undefined in the report:

(I'm not sure why this is not also linked for other User events as it seems useful to have a quick link to list the associated items for a given member...)

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5482 **Author:** [@stefan0xC](https://github.com/stefan0xC) **Created:** 1/27/2025 **Status:** ✅ Merged **Merged:** 1/28/2025 **Merged by:** [@BlackDex](https://github.com/BlackDex) **Base:** `main` ← **Head:** `add-additional-events` --- ### 📝 Commits (5) - [`c66935d`](https://github.com/dani-garcia/vaultwarden/commit/c66935db3a690a10d58fd9162b7617bb25bb4fa7) add additional event_types - [`1b9efc0`](https://github.com/dani-garcia/vaultwarden/commit/1b9efc0830b483e7b60c948c10a1acace1010226) use correct event_type when leaving an org - [`32d47fa`](https://github.com/dani-garcia/vaultwarden/commit/32d47faa3b2d1cd7148df758b720eb382f28ae6a) use correct event type when deleting a user - [`3d6f9cf`](https://github.com/dani-garcia/vaultwarden/commit/3d6f9cf3d636336120e614fc5208d89cd85d2f00) also correctly log auth requests - [`a7ef547`](https://github.com/dani-garcia/vaultwarden/commit/a7ef5475dd9795c18d6c2a0e38008645d5f33d80) add correct membership info to event log ### 📊 Changes **5 files changed** (+48 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/api/admin.rs` (+1 -1) 📝 `src/api/core/accounts.rs` (+26 -0) 📝 `src/api/core/events.rs` (+5 -4) 📝 `src/api/core/organizations.rs` (+1 -1) 📝 `src/db/models/event.rs` (+15 -0) </details> ### 📄 Description It seems like the web-vault has [some additional event types](https://github.com/bitwarden/clients/blob/web-v2025.1.1/libs/common/src/enums/event-type.enum.ts), so I've updated our list accordingly. Most of them are added only for reference (and it seems like the web-vault does not even have support to [display all of them correctly](https://github.com/bitwarden/clients/blob/web-v2025.1.1/apps/web/src/app/core/event.service.ts) at the moment). I've used the new ones for auth requests and to differentiate between a member leaving an organization  and getting the whole account deleted by an admin (<del>possibly this should also be when it's deleted by yourself?</del>).  Lastly I also changed it so that the membership info is also stored in the `log_user_event` for the found organizations, so the link to the member id won't show up as `undefined` in the report:  (I'm not sure why this is not also linked for other User events as it seems useful to have a quick link to list the associated items for a given member...) --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-05-22 01:54:05 -05:00

GiteaMirror closed this issue 2026-05-22 01:54:07 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#24492