don't show password hints if you have disabled the hints with PASSWORD_HINTS_ALLOWED=false or if you have not configured mail and also not opted into showing password hints
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/dani-garcia/vaultwarden/pull/5189
**Author:** [@stefan0xC](https://github.com/stefan0xC)
**Created:** 11/12/2024
**Status:** ✅ Merged
**Merged:** 11/12/2024
**Merged by:** [@dani-garcia](https://github.com/dani-garcia)
**Base:** `main` ← **Head:** `fix-password-hint`
---
### 📝 Commits (2)
- [`b224721`](https://github.com/dani-garcia/vaultwarden/commit/b224721c8aeb2627f01551995e60ff56ace15e44) fix password hint check
- [`611a1c3`](https://github.com/dani-garcia/vaultwarden/commit/611a1c303af61ada1b22896618429dd182c26635) update descriptions for pw hints options
### 📊 Changes
**3 files changed** (+9 additions, -8 deletions)
<details>
<summary>View changed files</summary>
📝 `.env.template` (+4 -3)
📝 `src/api/core/accounts.rs` (+1 -1)
📝 `src/config.rs` (+4 -4)
</details>
### 📄 Description
as noticed by @jjlin https://github.com/dani-garcia/vaultwarden/discussions/5179#discussioncomment-11230716 this is currently not correct.
don't show password hints if you have disabled the hints with `PASSWORD_HINTS_ALLOWED=false` or if you have not configured mail and also not opted into showing password hints
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/dani-garcia/vaultwarden/pull/5189
Author: @stefan0xC
Created: 11/12/2024
Status: ✅ Merged
Merged: 11/12/2024
Merged by: @dani-garcia
Base:
main← Head:fix-password-hint📝 Commits (2)
b224721fix password hint check611a1c3update descriptions for pw hints options📊 Changes
3 files changed (+9 additions, -8 deletions)
View changed files
📝
.env.template(+4 -3)📝
src/api/core/accounts.rs(+1 -1)📝
src/config.rs(+4 -4)📄 Description
as noticed by @jjlin https://github.com/dani-garcia/vaultwarden/discussions/5179#discussioncomment-11230716 this is currently not correct.
don't show password hints if you have disabled the hints with
PASSWORD_HINTS_ALLOWED=falseor if you have not configured mail and also not opted into showing password hints🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.