[PR #4242] [MERGED] Improve file limit handling #24263

New Issue

Closed

opened 2026-05-22 01:33:07 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-05-22 01:33:07 -05:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/4242
Author: @dani-garcia
Created: 1/12/2024
Status: ✅ Merged
Merged: 1/27/2024
Merged by: @dani-garcia

Base: main ← Head: improve_file_limits

---

📝 Commits (4)

• caca696 Improve file limit handling
• 9247481 Oops
• e63db03 Update PostgreSQL migration
• cc9e1ab Review comments

📊 Changes

26 files changed (+281 additions, -98 deletions)

View changed files

📝 .env.template (+4 -0)
📝 Cargo.lock (+26 -2)
📝 Cargo.toml (+2 -1)
➕ migrations/mysql/2024-01-12-210182_change_attachment_size/down.sql (+0 -0)
➕ migrations/mysql/2024-01-12-210182_change_attachment_size/up.sql (+1 -0)
➕ migrations/postgresql/2024-01-12-210182_change_attachment_size/down.sql (+0 -0)
➕ migrations/postgresql/2024-01-12-210182_change_attachment_size/up.sql (+3 -0)
➕ migrations/sqlite/2024-01-12-210182_change_attachment_size/down.sql (+0 -0)
➕ migrations/sqlite/2024-01-12-210182_change_attachment_size/up.sql (+1 -0)
📝 src/api/admin.rs (+4 -3)
📝 src/api/core/accounts.rs (+4 -2)
📝 src/api/core/ciphers.rs (+58 -20)
📝 src/api/core/emergency_access.rs (+4 -2)
📝 src/api/core/organizations.rs (+2 -3)
📝 src/api/core/sends.rs (+43 -23)
📝 src/api/core/two_factor/authenticator.rs (+2 -1)
📝 src/api/core/two_factor/mod.rs (+4 -2)
📝 src/api/core/two_factor/webauthn.rs (+2 -1)
📝 src/api/mod.rs (+0 -27)
📝 src/config.rs (+22 -0)

...and 6 more files

📄 Description

• Add separate Send limit, previously it was using the Attachment limit, which wouldn't work correctly
• Change file sizes in attachment to be i64, both in code and in the database, to limit the amount of number casting
• Switched number operations to use checked operations

Haven't tested MySQL or Postgres but I think the migrations are correct.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/4242 **Author:** [@dani-garcia](https://github.com/dani-garcia) **Created:** 1/12/2024 **Status:** ✅ Merged **Merged:** 1/27/2024 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `main` ← **Head:** `improve_file_limits` --- ### 📝 Commits (4) - [`caca696`](https://github.com/dani-garcia/vaultwarden/commit/caca696f56eb6766f637083f1008c2f27ef910cd) Improve file limit handling - [`9247481`](https://github.com/dani-garcia/vaultwarden/commit/9247481daeda3fc52326a75c3c39aa5f8f21eb2c) Oops - [`e63db03`](https://github.com/dani-garcia/vaultwarden/commit/e63db03c288d89a4823d90b63c4950598c59c23b) Update PostgreSQL migration - [`cc9e1ab`](https://github.com/dani-garcia/vaultwarden/commit/cc9e1ab79efab15cc1dc746160656c759f700b68) Review comments ### 📊 Changes **26 files changed** (+281 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `.env.template` (+4 -0) 📝 `Cargo.lock` (+26 -2) 📝 `Cargo.toml` (+2 -1) ➕ `migrations/mysql/2024-01-12-210182_change_attachment_size/down.sql` (+0 -0) ➕ `migrations/mysql/2024-01-12-210182_change_attachment_size/up.sql` (+1 -0) ➕ `migrations/postgresql/2024-01-12-210182_change_attachment_size/down.sql` (+0 -0) ➕ `migrations/postgresql/2024-01-12-210182_change_attachment_size/up.sql` (+3 -0) ➕ `migrations/sqlite/2024-01-12-210182_change_attachment_size/down.sql` (+0 -0) ➕ `migrations/sqlite/2024-01-12-210182_change_attachment_size/up.sql` (+1 -0) 📝 `src/api/admin.rs` (+4 -3) 📝 `src/api/core/accounts.rs` (+4 -2) 📝 `src/api/core/ciphers.rs` (+58 -20) 📝 `src/api/core/emergency_access.rs` (+4 -2) 📝 `src/api/core/organizations.rs` (+2 -3) 📝 `src/api/core/sends.rs` (+43 -23) 📝 `src/api/core/two_factor/authenticator.rs` (+2 -1) 📝 `src/api/core/two_factor/mod.rs` (+4 -2) 📝 `src/api/core/two_factor/webauthn.rs` (+2 -1) 📝 `src/api/mod.rs` (+0 -27) 📝 `src/config.rs` (+22 -0) _...and 6 more files_ </details> ### 📄 Description - Add separate Send limit, previously it was using the Attachment limit, which wouldn't work correctly - Change file sizes in attachment to be i64, both in code and in the database, to limit the amount of number casting - Switched number operations to use checked operations Haven't tested MySQL or Postgres but I think the migrations are correct. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-05-22 01:33:07 -05:00

GiteaMirror closed this issue 2026-05-22 01:33:08 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

various_fixes

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

GiteaMirror ninjasurge (Kaehlen Rog)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#24263