[PR #257] [MERGED] Fixes NFC Response for Mobile Yubikey OTP Login #23559

New Issue

Closed

opened 2026-05-22 00:23:15 -05:00 by GiteaMirror · 0 comments

GiteaMirror commented 2026-05-22 00:23:15 -05:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/dani-garcia/vaultwarden/pull/257
Author: @Step7750
Created: 11/17/2018
Status: ✅ Merged
Merged: 11/17/2018
Merged by: @dani-garcia

Base: master ← Head: fix-nfc-mobile

---

📝 Commits (1)

• f344dba Fixes NFC Response for Mobile Login

📊 Changes

2 files changed (+15 additions, -2 deletions)

View changed files

📝 src/api/core/two_factor.rs (+2 -2)
📝 src/api/identity.rs (+13 -0)

📄 Description

With Yubikey OTP introduced in #254, it doesn't return whether Nfc should be enabled to the mobile client during login. As a result, the mobile client crashes upon login.

This PR returns the proper NFC value saved by the user in 2FA Yubikey OTP settings.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/dani-garcia/vaultwarden/pull/257 **Author:** [@Step7750](https://github.com/Step7750) **Created:** 11/17/2018 **Status:** ✅ Merged **Merged:** 11/17/2018 **Merged by:** [@dani-garcia](https://github.com/dani-garcia) **Base:** `master` ← **Head:** `fix-nfc-mobile` --- ### 📝 Commits (1) - [`f344dba`](https://github.com/dani-garcia/vaultwarden/commit/f344dbaad407d3d3b2255628a09fc28a947a34c1) Fixes NFC Response for Mobile Login ### 📊 Changes **2 files changed** (+15 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/api/core/two_factor.rs` (+2 -2) 📝 `src/api/identity.rs` (+13 -0) </details> ### 📄 Description With Yubikey OTP introduced in #254, it doesn't return whether Nfc should be enabled to the mobile client during login. As a result, the mobile client crashes upon login. This PR returns the proper NFC value saved by the user in 2FA Yubikey OTP settings. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

GiteaMirror added the pull-request label 2026-05-22 00:23:15 -05:00

GiteaMirror closed this issue 2026-05-22 00:23:16 -05:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

revert-7033-patch-1

cached-config-operations

test_dylint

1.36.0

1.35.8

1.35.7

1.35.6

1.35.5

1.35.4

1.35.3

1.35.2

1.35.1

1.35.0

1.34.3

1.34.2

1.34.1

1.34.0

1.33.2

1.33.1

1.33.0

1.32.7

1.32.6

1.32.5

1.32.4

1.32.3

1.32.2

1.32.1

1.32.0

1.31.0

1.30.5

1.30.4

1.30.3

1.30.2

1.30.1

1.30.0

1.29.2

1.29.1

1.29.0

1.28.1

1.28.0

1.27.0

1.26.0

1.25.2

1.25.1

1.25.0

1.24.0

1.23.1

1.23.0

1.22.2

1.22.1

1.22.0

1.21.0

1.20.0

1.19.0

1.18.0

1.17.0

1.16.3

1.16.2

1.16.1

1.16.0

1.15.1

1.15.0

1.14.2

1.14.1

1.14

1.13.1

1.13.0

1.12.0

1.11.0

1.10.0

1.9.1

1.9.0

1.8.0

1.7.0

1.6.1

1.6.0

1.5.0

1.4.0

1.3.0

1.2.0

1.1.0

1.0.0

0.13.0

0.12.0

0.11.0

0.10.0

0.9.0

Labels

Clear labels

better for forum

bug

documentation

duplicate

enhancement

future Vault

good first issue

help wanted

low priority

notes

pull-request

Mirrored from GitHub Pull Request

question

SSO

Third party

troubleshooting

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

GiteaMirror ninjasurge

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vaultwarden#23559